From a5274115084989f9765b2f68a6d5dc9a021fc18d Mon Sep 17 00:00:00 2001
From: vipul674 <vipulponugoti@gmail.com>
Date: Sat, 27 Jun 2026 13:39:51 +0530
Subject: [PATCH] fix: throw on unauthenticated user in syncOfflineQueue

Previously skipped all sessions silently when user not authenticated,
orphaning queued data. Now throws early with clear error message.

Closes #939
---
 src/services/syncQueue.ts | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/services/syncQueue.ts b/src/services/syncQueue.ts
index 0eb02849..f224b55c 100644
--- a/src/services/syncQueue.ts
+++ b/src/services/syncQueue.ts
@@ -50,12 +50,16 @@ async function uploadReplaySession(session: ReplaySession): Promise<void> {
  */
 export async function syncOfflineQueue(): Promise<SyncResult> {
   const currentUserId = getAuth().currentUser?.uid;
+  if (!currentUserId) {
+    throw new Error("User not authenticated — cannot sync offline queue");
+  }
+
   const queue = getQueue();
   let synced = 0;
   let failed = 0;
 
   for (const session of queue) {
-    if (!currentUserId || session.userId !== currentUserId) {
+    if (session.userId !== currentUserId) {
       continue;
     }
     try {