OnSessionCancelled gets called right after OnSessionStarted

[mewais]

Hi there,

I'm building a JuiceSSH plugin, and like it says in the title, I get calls to OnSessionCancelled right after OnSessionStarted. looking at the file here I think line 286 is missing a break;?

I guess the reason this passed uncaught before is because in the example plugin and performance monitors use an empty OnSessionCancelled callback.

[1951FDG]

Hi @mewais,

You're absolutely right!

fallthrough in switch statements is a cause of bugs!

**Fallthrough in 'switch' statement less... (⌘F1)** 
Reports 'fall-through' in a switch statement. Fall-through is defined to occur when a 
series of executable statements after a switch label is not guaranteed to transfer 
control before the next switch label. In that case, control falls through to the 
statements after that switch label, even though the switch expression does not equal the 
value of the fallen-through label. While occasionally intended, this construction is 
confusing, and is often the result of a typo.

I've forked this repo and made some minor changes including a bugfix for this particular issue!!
https://github.com/1951FDG/juicessh-pluginlibrary

My fork is available as a JitPack repository
https://jitpack.io/#1951FDG/juicessh-pluginlibrary