From c78a07d20a24d4e00d9df81eab23ef8e1bad8a61 Mon Sep 17 00:00:00 2001 From: Busslina Date: Fri, 10 Jan 2025 23:09:25 +0100 Subject: [PATCH 1/2] Added log level comparison operators --- lib/src/log_level.dart | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/src/log_level.dart b/lib/src/log_level.dart index 7b9976b..f1a55dc 100644 --- a/lib/src/log_level.dart +++ b/lib/src/log_level.dart @@ -20,4 +20,12 @@ enum Level { final int value; const Level(this.value); + + bool operator <(Level other) => index < other.index; + + bool operator <=(Level other) => index <= other.index; + + bool operator >(Level other) => index > other.index; + + bool operator >=(Level other) => index >= other.index; } From 3b7e6c8ebfeb383a07c16e94600333b30e048196 Mon Sep 17 00:00:00 2001 From: Busslina Date: Fri, 10 Jan 2025 23:59:16 +0100 Subject: [PATCH 2/2] Updated log level comparison operators --- lib/src/filters/development_filter.dart | 2 +- lib/src/filters/production_filter.dart | 2 +- lib/src/log_level.dart | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/src/filters/development_filter.dart b/lib/src/filters/development_filter.dart index cc4553d..a2414e2 100644 --- a/lib/src/filters/development_filter.dart +++ b/lib/src/filters/development_filter.dart @@ -10,7 +10,7 @@ class DevelopmentFilter extends LogFilter { bool shouldLog(LogEvent event) { var shouldLog = false; assert(() { - if (event.level.value >= level!.value) { + if (event.level >= level!) { shouldLog = true; } return true; diff --git a/lib/src/filters/production_filter.dart b/lib/src/filters/production_filter.dart index 214efb7..533b0b2 100644 --- a/lib/src/filters/production_filter.dart +++ b/lib/src/filters/production_filter.dart @@ -5,6 +5,6 @@ import '../log_filter.dart'; class ProductionFilter extends LogFilter { @override bool shouldLog(LogEvent event) { - return event.level.value >= level!.value; + return event.level >= level!; } } diff --git a/lib/src/log_level.dart b/lib/src/log_level.dart index f1a55dc..1c89c1a 100644 --- a/lib/src/log_level.dart +++ b/lib/src/log_level.dart @@ -21,11 +21,11 @@ enum Level { const Level(this.value); - bool operator <(Level other) => index < other.index; + bool operator <(Level other) => value < other.value; - bool operator <=(Level other) => index <= other.index; + bool operator <=(Level other) => value <= other.value; - bool operator >(Level other) => index > other.index; + bool operator >(Level other) => value > other.value; - bool operator >=(Level other) => index >= other.index; + bool operator >=(Level other) => value >= other.value; }