Skip to content

Commit 892f989

Browse files
authored
Merge pull request #159 from SpringRoll/bugfix/captions-styles-plugin
Plugin name fix
2 parents 3a932e7 + f67f17f commit 892f989

File tree

6 files changed

+7
-6
lines changed

6 files changed

+7
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1010
### Fixed
1111

1212
- CaptionsStylesPlugin now correctly updates radio button status when the style is changed programatically
13+
- Changed CaptionsStylePlugin to have distinct name
1314

1415
## [2.4.4] 2023-02-27
1516

dist/SpringRoll-Container-umd.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/SpringRoll-Container-umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/plugins/CaptionsStylePlugin.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export class CaptionsStylePlugin extends ButtonPlugin {
4646
constructor(fontSizeRadios, colorRadios, alignmentRadios,
4747
{ defaultFontSize = 'medium', defaultColor = 'default', defaultAlignment = 'top' } = {}
4848
) {
49-
super('Caption-Button-Plugin');
49+
super('Caption-Style-Plugin');
5050
this.sendAllProperties = this.sendAllProperties.bind(this);
5151
this.captionsStyles = Object.assign(
5252
{},
@@ -321,7 +321,7 @@ export class CaptionsStylePlugin extends ButtonPlugin {
321321

322322
// update radios to match
323323
this.colorRadios.forEach((group) => {
324-
const style = this.captionsStyles.color === 'white' ? 'default' : 'inverted'
324+
const style = this.captionsStyles.color === 'white' ? 'default' : 'inverted';
325325
group.radioGroup[style].checked = true;
326326
});
327327
this.alignmentRadios.forEach((group) => {

0 commit comments

Comments
 (0)