Skip to content

Commit bdc6e6f

Browse files
validation for positive ineteger in delay input box
1 parent 86a3dec commit bdc6e6f

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

modules/st2flow-details/orquesta-properties.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ export default class OrquestaTransition extends Component<TransitionProps, {}> {
5454

5555
handleTaskProperty(name: string | Array<string>, value: any, noDelete: boolean = false) {
5656
const { task, issueModelCommand } = this.props;
57+
5758
if (value || noDelete) {
5859
issueModelCommand && issueModelCommand('setTaskProperty', task, name, value);
5960
}
@@ -62,10 +63,8 @@ export default class OrquestaTransition extends Component<TransitionProps, {}> {
6263
}
6364
}
6465

65-
isValidInput(value, returnvalue = '') {
66-
if (!isNaN(value) && value < 0) {
67-
return returnvalue;
68-
}
66+
getValue(value) {
67+
if(!isNaN(value) && value!== '') value = parseInt(value,10);
6968
return value;
7069
}
7170

@@ -119,10 +118,10 @@ export default class OrquestaTransition extends Component<TransitionProps, {}> {
119118
id="delayField"
120119
size="3"
121120
className={this.style.delayField}
122-
value={this.isValidInput(task.delay)}
121+
value={(task.delay)}
123122
placeholder ="enter expression or integer"
124-
onChange={e => this.handleTaskProperty('delay',e.target.value, true)}
125-
onBlur={ e => this.handleTaskProperty('delay', e.target.value, true)}
123+
onChange={e => this.handleTaskProperty('delay',this.getValue(e.target.value), true)}
124+
onBlur={ e => this.handleTaskProperty('delay',this.getValue(e.target.value), true)}
126125
/>
127126
</label>
128127
</div>

0 commit comments

Comments
 (0)