Fix all the various lint violations detected by eslint.

Kami · Kami · commit f53595b251c7 · 2021-04-04T21:14:09.000+02:00
diff --git a/.eslintignore b/.eslintignore
@@ -3,3 +3,4 @@ modules/*/node_modules
 tasks/*/node_modules
 node_modules
 js
+package.meta.js
diff --git a/apps/st2-actions/actions-details.component.js b/apps/st2-actions/actions-details.component.js
@@ -213,9 +213,11 @@ export default class ActionsDetails extends React.Component {
       },
     });
   }
-setWindowName(e){
-   window.name="parent"
-}
+
+  setWindowName(e) {
+    window.name = 'parent';
+  }
+
   handleRun(e, ...args) {
     e.preventDefault();
 
@@ -259,7 +261,7 @@ setWindowName(e){
                   target="_blank"
                   to={`/action/${action.ref}`}
                   className="st2-forms__button st2-details__toolbar-button"
-                  onClick ={e => this.setWindowName(e)}
+                  onClick={e => this.setWindowName(e)}
                 >
                   Edit
                 </Link>
diff --git a/apps/st2-history/history-details.component.js b/apps/st2-history/history-details.component.js
@@ -56,7 +56,7 @@ export default class HistoryDetails extends React.Component {
 
     id: PropTypes.string,
     section: PropTypes.string,
-    execution: PropTypes.object,
+    execution: PropTypes.object, // eslint-disable-line react/no-unused-prop-types
     displayUTC: PropTypes.bool.isRequired,
     handleToggleUTC: PropTypes.func,
   }
@@ -74,7 +74,7 @@ export default class HistoryDetails extends React.Component {
   }
 
   componentDidUpdate(prevProps) {
-    const { id, execution } = this.props;
+    const { id } = this.props;
 
     if (id && id !== prevProps.id) {
       this.fetchExecution(id);
diff --git a/apps/st2-workflows/workflows.component.js b/apps/st2-workflows/workflows.component.js
@@ -73,7 +73,7 @@ export default class Workflows extends Component {
    pack: PropTypes.string,
    meta: PropTypes.object,
    metaSource: PropTypes.string,
-   setMeta: PropTypes.func,
+   setMeta: PropTypes.func,  // eslint-disable-line react/no-unused-prop-types
    input: PropTypes.array,
    workflowSource: PropTypes.string,
    dirty: PropTypes.bool,
@@ -243,7 +243,7 @@ export default class Workflows extends Component {
  }
 
  save() {
-   const { pack, meta, actions, workflowSource, metaSource, setMeta } = this.props;
+   const { pack, meta, actions, workflowSource, metaSource } = this.props;
    const existingAction = actions.find(e => e.name === meta.name && e.pack === pack);
 
    if (!meta.name) {
diff --git a/modules/st2-action-reporter/action-reporter.component.js b/modules/st2-action-reporter/action-reporter.component.js
@@ -42,19 +42,19 @@ const DEFAULT_MAX_RESULT_SIZE = 100 * 1024;  // 100 KB
  */
 function getBaseAPIUrl(api) {
   if (!api.server) {
-    console.log("config.js is not correctly configured - it's missing API server URL entry")
+    console.log('config.js is not correctly configured - it\'s missing API server URL entry');
     return null;
   }
 
   if (!api.server.api) {
-    console.log("config.js is not correctly configured - it's missing API server URL entry")
+    console.log('config.js is not correctly configured - it\'s missing API server URL entry');
     return null;
   }
 
-  var url = api.server.api;
-  var baseUrl;
+  const url = api.server.api;
+  let baseUrl;
 
-  if (!url.startsWith("http://") && !(url.startsWith("https://"))) {
+  if (!url.startsWith('http://') && !(url.startsWith('https://'))) {
     baseUrl = `${window.location.protocol}${url}`;
   }
   else {
@@ -71,7 +71,7 @@ function getBaseAPIUrl(api) {
  * We specify a default value which can be overriden inside the config.
  */
 function getMaxExecutionResultSizeForRender() {
-  var maxResultSizeForRender;
+  let maxResultSizeForRender;
 
   try {
     maxResultSizeForRender = window.st2constants.st2Config.max_execution_result_size_for_render || DEFAULT_MAX_RESULT_SIZE;
@@ -88,6 +88,7 @@ export default class ActionReporter extends React.Component {
     className: PropTypes.string,
     runner: PropTypes.string.isRequired,
     execution: PropTypes.object.isRequired,
+    api: PropTypes.object.isRequired,
   }
 
   static utils = {
@@ -119,12 +120,12 @@ export default class ActionReporter extends React.Component {
 
       return (
         <div {...props} className={cx(style.component, className)}>
-        <div key="output" className={style.source}>Output</div>
+          <div key="output" className={style.source}>Output</div>
           <p>
-          Action output is too large to be displayed here ({`${resultSizeMB}`} MB).<br /><br />You can view raw execution output by clicking <a href={`${viewRawResultUrl}`} target="_blank">here</a> or you can download the output by clicking <a href={`${downloadRawResultUrl}`} target="_blank">here (uncompressed)</a> or <a href={`${downloadCompressedRawResultUrl}`} target="_blank">here (compressed)</a>.
+            Action output is too large to be displayed here ({`${resultSizeMB}`} MB).<br /><br />You can view raw execution output by clicking <a href={`${viewRawResultUrl}`} target="_blank" rel="noopener noreferrer">here</a> or you can download the output by clicking <a href={`${downloadRawResultUrl}`} target="_blank" rel="noopener noreferrer">here (uncompressed)</a> or <a href={`${downloadCompressedRawResultUrl}`} target="_blank" rel="noopener noreferrer">here (compressed)</a>.
           </p>
         </div>
-        );
+      );
     }
 
     return (
diff --git a/modules/st2-action-reporter/tests/test-action-reporter.js b/modules/st2-action-reporter/tests/test-action-reporter.js
@@ -25,10 +25,10 @@ describe(`${ActionReporter.name} Component`, () => {
     it('proxies className', () => {
       const instance = ReactTester.create(
         <ActionReporter
-          className="foobar"
-          runner="noop"
+          className='foobar'
+          runner='noop'
           execution={{}}
-          api={{server: {api: "https://example.com:3000/v1"}}}
+          api={{server: {api: 'https://example.com:3000/v1'}}}
         />
       );
 
@@ -38,10 +38,10 @@ describe(`${ActionReporter.name} Component`, () => {
     it('proxies extra props', () => {
       const instance = ReactTester.create(
         <ActionReporter
-          foo="bar"
-          runner="noop"
+          foo='bar'
+          runner='noop'
           execution={{}}
-          api={{server: {api: "https://example.com:3000/v1"}}}
+          api={{server: {api: 'https://example.com:3000/v1'}}}
         />
       );
 
@@ -51,16 +51,16 @@ describe(`${ActionReporter.name} Component`, () => {
     it('returns correct message on large result', () => {
       const instance = ReactTester.create(
         <ActionReporter
-          foo="bar"
-          runner="noop"
-          execution={{id: "id1", result_size: 500 * 10244}}
-          api={{server: {api: "https://example.com:3000/v1"}}}
+          foo='bar'
+          runner='noop'
+          execution={{id: 'id1', result_size: 500 * 10244}}
+          api={{server: {api: 'https://example.com:3000/v1'}}}
         />
       );
 
-      const pElem = instance.toJSON()["children"][1].children.join("");
-      expect(pElem).to.contain("Action output is too large to be displayed here")
-      expect(pElem).to.contain("You can view raw")
+      const pElem = instance.toJSON().children[1].children.join('');
+      expect(pElem).to.contain('Action output is too large to be displayed here');
+      expect(pElem).to.contain('You can view raw');
     });
   });
 });
diff --git a/modules/st2-api/api.js b/modules/st2-api/api.js
@@ -175,28 +175,29 @@ export class API {
 
     const headers = {
       'content-type': 'application/json',
-      
-
     };
 
     if (this.token && this.token.token) {
       headers['x-auth-token'] = this.token.token;
     }
-    
+
     const config = {
       method,
       url: this.route(opts),
       params: query,
       headers,
-      transformResponse: [function transformResponse(data, headers) {
-      if (typeof data === 'string' && headers["content-type"] === "application/json") {
-      try {
-        data = JSON.parse(data);
-      } catch (e) { /* Ignore */ }
-    }
-    return data;
-      }
-  ],
+      transformResponse: [ function transformResponse(data, headers) {
+        if (typeof data === 'string' && headers['content-type'] === 'application/json') {
+          try {
+            data = JSON.parse(data);
+          }
+          catch (e) {
+            /* Ignore */
+          }
+        }
+
+        return data;
+      } ],
       data,
       withCredentials: true,
       paramsSerializer: params => {
diff --git a/modules/st2-menu/menu.component.js b/modules/st2-menu/menu.component.js
@@ -84,11 +84,11 @@ export default class Menu extends React.Component {
     const server = api.server;
     const showVersion = window.st2constants.st2Config.show_version_in_header || false;
     const hasPackageMeta = (window.st2constants.st2PackageMeta !== undefined);
-    const st2webCommitsUrl = (showVersion && hasPackageMeta) ? "https://github.com/StackStorm/st2web/commit/" + window.st2constants.st2PackageMeta.git_sha : ""
+    const st2webCommitsUrl = (showVersion && hasPackageMeta) ? `https://github.com/StackStorm/st2web/commit/${window.st2constants.st2PackageMeta.git_sha}` : '';
 
     return (
       <header {...props} className={cx(style.component, className)}>
-        <a href="#" className={style.logo} /> { (showVersion && hasPackageMeta) ? <span style={{ fontSize: 15, marginTop: 30 }}>st2: v{window.st2constants.st2PackageMeta.version}, st2web: <a href={st2webCommitsUrl} target="_blank">{window.st2constants.st2PackageMeta.git_sha}</a></span> : '' }
+        <a href="#" className={style.logo} /> { (showVersion && hasPackageMeta) ? <span style={{ fontSize: 15, marginTop: 30 }}>st2: v{window.st2constants.st2PackageMeta.version}, st2web: <a href={st2webCommitsUrl} target="_blank" rel="noopener noreferrer">{window.st2constants.st2PackageMeta.git_sha}</a></span> : '' }
 
         <div className={style.spacer} />
 
diff --git a/modules/st2-pack-icon/pack-icon.component.js b/modules/st2-pack-icon/pack-icon.component.js
@@ -82,9 +82,11 @@ export default class PackIcon extends React.Component {
           <img src="img/icon.png" width="32" height="32" />
         );
       }
+      /* Unreachable code, commented out :shrug:
       return (
         <img className={cx(style.image, small && style.imageSmall)} src={icons[name]} />
       );
+      */
       // ^^ WAT?
     }
 
diff --git a/modules/st2-time/tests/test-time.js b/modules/st2-time/tests/test-time.js
@@ -20,9 +20,9 @@ import { ReactTester } from '@stackstorm/module-test-utils';
 import Time from '..';
 
 function isDST(d) {
-    let jan = new Date(d.getFullYear(), 0, 1).getTimezoneOffset();
-    let jul = new Date(d.getFullYear(), 6, 1).getTimezoneOffset();
-    return Math.max(jan, jul) != d.getTimezoneOffset(); 
+  const jan = new Date(d.getFullYear(), 0, 1).getTimezoneOffset();
+  const jul = new Date(d.getFullYear(), 6, 1).getTimezoneOffset();
+  return Math.max(jan, jul) !== d.getTimezoneOffset();
 }
 
 describe(`${Time.name} Component`, () => {
diff --git a/modules/st2flow-canvas/index.js b/modules/st2flow-canvas/index.js
@@ -22,7 +22,6 @@ import  {
   TransitionInterface,
 } from '@stackstorm/st2flow-model/interfaces';
 import  { NotificationInterface } from '@stackstorm/st2flow-notifications';
-import  { Node } from 'react';
 
 import React, { Component } from 'react';
 import { connect } from 'react-redux';
@@ -48,7 +47,6 @@ import PoissonRectangleSampler from './poisson-rect';
 import { origin } from './const';
 
 import style from './style.css';
-import store from '../../apps/st2-workflows/store';
 type DOMMatrix = {
   m11: number,
   m22: number
@@ -228,6 +226,9 @@ export default class Canvas extends Component {
     nextTask: PropTypes.string,
     isCollapsed: PropTypes.object,
     toggleCollapse: PropTypes.func,
+    dirtyflag: PropTypes.bool,
+    fetchActionscalled: PropTypes.func,
+    saveData: PropTypes.func,
   }
 
   state = {
diff --git a/modules/st2flow-details/orquesta-properties.js b/modules/st2flow-details/orquesta-properties.js
@@ -46,7 +46,6 @@ type TransitionProps = {
   })
 )
 export default class OrquestaTransition extends Component<TransitionProps, {}> {
-  
   static propTypes = {
     task: PropTypes.object.isRequired,
     issueModelCommand: PropTypes.func,
@@ -64,7 +63,10 @@ export default class OrquestaTransition extends Component<TransitionProps, {}> {
   }
 
   getValue(value) {
-    if(!isNaN(value) && value!== '') value = parseInt(value,10);
+    if (!isNaN(value) && value !== '') {
+      value = parseInt(value,10);
+    }
+
     return value;
   }
 
@@ -119,20 +121,20 @@ export default class OrquestaTransition extends Component<TransitionProps, {}> {
       <Property key="delay" name="Delay" description="Add delay before task execution" value={task.delay != null} onChange={value => this.handleTaskProperty('delay', value ? '10' : false)}>
         {
           task.delay != null && (
-           <div className={this.style.propertyChild}>
-            <label htmlFor="delay" >
+            <div className={this.style.propertyChild}>
+              <label htmlFor="delay" >
                 delay (seconds)
                 <input
                   type="text"
                   id="delayField"
                   size="3"
                   className={this.style.delayField}
                   value={(task.delay)}
-                  placeholder ="enter expression or integer"
+                  placeholder="enter expression or integer"
                   onChange={e => this.handleTaskProperty('delay',this.getValue(e.target.value), true)}
-                  onBlur={ e => this.handleTaskProperty('delay',this.getValue(e.target.value), true)} 
+                  onBlur={e => this.handleTaskProperty('delay',this.getValue(e.target.value), true)} 
                 />
-            </label>
+              </label>
             </div>
           )
         }
@@ -143,7 +145,7 @@ export default class OrquestaTransition extends Component<TransitionProps, {}> {
             <div className={this.style.propertyChild}>
               <StringField name="when" value={task.retry.when} className="when-title" onChange={value => this.handleTaskProperty([ 'retry', 'when' ], value)} spec={{'default':'enter expression'}}  />
               <StringField name="count" value={task.retry.count} className="count-title" onChange={value => this.handleTaskProperty([ 'retry', 'count' ], this.getValue(value))}  spec={{'default':'enter expression or integer'}} />
-              <StringField name="delay (seconds)" value={task.retry.delay} className="delay-title" onChange={value => this.handleTaskProperty([ 'retry', 'delay'], this.getValue(value))} spec={{'default':'enter expression or integer'}} />
+              <StringField name="delay (seconds)" value={task.retry.delay} className="delay-title" onChange={value => this.handleTaskProperty([ 'retry', 'delay' ], this.getValue(value))} spec={{'default':'enter expression or integer'}} />
             </div>
           )
         }
diff --git a/modules/st2flow-header/index.js b/modules/st2flow-header/index.js
@@ -59,8 +59,8 @@ export default class Header extends Component<{
 
     return (
       <div className={cx(this.props.className, this.style.component)}>
-       <a href="#" className={style.logo} />
-       
+        <a href="#" className={style.logo} />
+
         <div className={this.style.separator} />
         {
           api.token && api.server && (
diff --git a/modules/st2flow-model/base-class.js b/modules/st2flow-model/base-class.js
@@ -76,14 +76,11 @@ class BaseClass {
 
         err.message = err.message.replace('JS-YAML:', 'YAML Parser:');
         notification.error(err.message);
-       
       });
 
       this.yaml = yaml;
-      
       this.emitError(exception, STR_ERROR_YAML);
-       return;
-     
+      return;
     }
 
     this.emitChange(oldTree);
diff --git a/modules/st2flow-notifications/index.js b/modules/st2flow-notifications/index.js
@@ -46,9 +46,9 @@ class Notification extends Component {
   style = style
 
   redirectLinkToParent = (e,newlink) => {
-     e.preventDefault();
-     var goBack = window.open(newlink, 'parent');
-     goBack.focus();
+    e.preventDefault();
+    const goBack = window.open(newlink, 'parent');
+    goBack.focus();
   }
 
   render() {
diff --git a/modules/st2flow-palette/pack.js b/modules/st2flow-palette/pack.js
@@ -71,8 +71,7 @@ export default class Action extends Component<{
             <i className={open ? 'icon-chevron_down palette-chevron-icon' : 'icon-chevron_right palette-chevron-icon'} />
           </div>
           <img ref={this.imgRef} src={api.route({ path: `/packs/views/file/${name}/icon.png` })} width="32" height="32" onError={() => this.handleImageError()} />
-           <h2 className="pack-name-heading"> { name }</h2>
-         
+          <h2 className="pack-name-heading"> { name }</h2>
         </div>
         {
           open && children
diff --git a/tasks/production/package-metadata.js b/tasks/production/package-metadata.js
@@ -33,7 +33,7 @@ gulp.task('production-package-metadata', (done) => {
   fs.writeFileSync(file_path_1, data_1);
 
   // Write it to .js file
-  const data_2 = `angular.module('main').constant('st2PackageMeta', { version: "${pkg_version}", git_sha: "${git_sha}"});\n`
+  const data_2 = `/* global angular */\nangular.module('main').constant('st2PackageMeta', { version: "${pkg_version}", git_sha: "${git_sha}"});\n`;
   const file_path_2 = path.join(path.resolve('./build'), 'package.meta.js');
   fs.writeFileSync(file_path_2, data_2);
 

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ export default class HistoryDetails extends React.Component {`
`56`	`56`
`57`	`57`	`id: PropTypes.string,`
`58`	`58`	`section: PropTypes.string,`
`59`		`- execution: PropTypes.object,`
	`59`	`+ execution: PropTypes.object, // eslint-disable-line react/no-unused-prop-types`
`60`	`60`	`displayUTC: PropTypes.bool.isRequired,`
`61`	`61`	`handleToggleUTC: PropTypes.func,`
`62`	`62`	`}`
`@@ -74,7 +74,7 @@ export default class HistoryDetails extends React.Component {`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`componentDidUpdate(prevProps) {`
`77`		`- const { id, execution } = this.props;`
	`77`	`+ const { id } = this.props;`
`78`	`78`
`79`	`79`	`if (id && id !== prevProps.id) {`
`80`	`80`	`this.fetchExecution(id);`
Original file line number	Diff line number	Diff line change
`@@ -82,9 +82,11 @@ export default class PackIcon extends React.Component {`
`82`	`82`	`<img src="img/icon.png" width="32" height="32" />`
`83`	`83`	`);`
`84`	`84`	`}`
	`85`	`+ /* Unreachable code, commented out :shrug:`
`85`	`86`	`return (`
`86`	`87`	`<img className={cx(style.image, small && style.imageSmall)} src={icons[name]} />`
`87`	`88`	`);`
	`89`	`+ */`
`88`	`90`	`// ^^ WAT?`
`89`	`91`	`}`
`90`	`92`