Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect name for A2 bomb rack #70

Open
alistair3149 opened this issue Jun 17, 2023 · 4 comments
Open

Incorrect name for A2 bomb rack #70

alistair3149 opened this issue Jun 17, 2023 · 4 comments
Labels
gamedata issue The issue is due to faulty game data

Comments

@alistair3149
Copy link
Contributor

A2 bomb rack (BMBRCK_CRUS_STARL_Left) has the name MSD-313 Missile Rack.
https://github.com/StarCitizenWiki/scunpacked-data/blob/3cfde6041ea161d09b721ef42e278598468c0b2a/v2/items/bmbrck_crus_starl_left.json#L4
@octfx
Copy link
Member

octfx commented Jun 17, 2023

Isn't that the current output on the API?
image

@alistair3149
Copy link
Contributor Author

Yeah, I'm wondering if that's an issue with how SCUnpacked is parsing the data since there's no way it is the msd-313. How did it get the localization info? https://github.com/StarCitizenWiki/scunpacked-data/blob/3cfde6041ea161d09b721ef42e278598468c0b2a/v2/items/bmbrck_crus_starl_left-raw.json#L160

@octfx
Copy link
Member

octfx commented Jun 18, 2023

Ah, got it!
Looking at the game data the A2 indeed has a MSD-313 Missile Rack equipped
image
image

@alistair3149
Copy link
Contributor Author

That is so weird. I guess both Erkul and SPV ignore the localization string for that then

@octfx octfx added the gamedata issue The issue is due to faulty game data label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gamedata issue The issue is due to faulty game data
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@octfx @alistair3149