[Tests] Unit & Integration Tests for OpenZeppelin-Based Non-Fungible Promotion NFT Contract

[aguilar1x]

🎯 Objective

Implement a complete test suite for the Promotion NFT Contract built with OpenZeppelin’s Stellar contracts, ensuring that minting, redemption, transfer, access control, and event emission work as expected for non-fungible promotional NFTs (e.g., discount codes, access passes).

---

🧪 Scope

Test the following modules and behaviors:

promotion-nft-contract/src/

  mint.rs           // One-off NFT minting with metadata
  redeem.rs         // Redemption flow (mark as used)
  transfer.rs       // Ownership transfers
  roles.rs          // Role-based access control
  metadata.rs       // Token-specific metadata access
  storage.rs        // NFT ownership, state, redemption tracking
  lib.rs            // Contract entry and initialization

---

✅ Test Categories & Cases

1. Initialization

• ✅ Only one call to initialize() allowed
• ✅ DEFAULT_ADMIN_ROLE correctly set
• ✅ Revert on second initialization
• ✅ Emit ContractInitialized only once

2. Role Management

• ✅ Only ADMIN_ROLE can grant MINTER_ROLE
• ✅ Only REDEEMER_ROLE (if used) can redeem on behalf of users
• ✅ Revert on unauthorized role access
• ✅ Events: RoleGranted, RoleRevoked

3. Minting Logic

• ✅ Only minters can mint (mint_promo(recipient, metadata_uri))
• ✅ Revert on unauthorized mint
• ✅ Revert if recipient is invalid
• ✅ Token ID must be unique
• ✅ Metadata URI stored and retrievable
• ✅ Emit PromoMinted(token_id, recipient)

4. Redemption Logic

• ✅ User can redeem if they own the token
• ✅ Optional: allow redemption by REDEEMER_ROLE
• ✅ Cannot redeem the same token twice
• ✅ Mark token as redeemed in storage
• ✅ Emit Redeemed(token_id, user, timestamp)
• ✅ Prevent transfers after redemption (if enforced)

5. Transfer Logic

• ✅ Owner can transfer to another valid address
• ✅ Ownership updates after transfer
• ✅ Revert if non-owner tries to transfer
• ✅ Emit Transfer(from, to, token_id)
• ✅ Optional: disallow transfer after redemption

6. Metadata Access

• ✅ Metadata URI must match what was minted
• ✅ Immutable after mint
• ✅ Test uniqueness of metadata per token
• ✅ Query metadata by token_id

7. Storage Integrity

• ✅ Ensure token IDs are never duplicated
• ✅ Validate redemption status is persisted
• ✅ No overwrites of metadata or ownership
• ✅ All keys follow expected isolation pattern

8. Event Emission

• ✅ Verify all relevant events:

  • ContractInitialized
  • PromoMinted
  • Redeemed
  • Transfer
  • RoleGranted, RoleRevoked

• ✅ Event values should be correct and consistent

---

🧰 Tooling & Environment

• Use soroban-sdk test helpers and mocks

• Organize tests into modules by feature: mint_tests, redeem_tests, transfer_tests, roles_tests

• Use representative mock accounts:

  • admin, seller, buyer1, redeemer

---

📌 Additional Recommendations

• Cover edge cases (mint same token twice, redeem twice, transfer after redemption)
• Use mock timestamps to test redemption timing (optional)
• Prepare for future extension to burn-on-redeem logic
• Structure test assertions for easy CI logging

---

🔗 References

• OpenZeppelin Stellar Contracts

---

[Yunusabdul38]

I'd love to take this on!

I'm a blockchain developer with a background in Rust and Rust Sorroban. I would like to work on this. I'm ready to get started immediately if assigned

Recommended by OnlyDust for high-quality and dependable contributions.

[armandocodecr]

Hello team!

I’d like to take on the task of implementing the full test suite for the Promotion NFT Contract. I have hands-on experience writing comprehensive tests for Soroban contracts using soroban-sdk helpers and mocks, with a focus on roles, permissions, and event verification — exactly the kind of structure this issue requires.

My plan would be to break down the tests by feature module (e.g., minting, redeeming, transfers, etc.), ensuring clarity and maintainability. I’ll also take care to validate event consistency, edge cases like repeated redemptions or unauthorized access, and provide clean assertions for CI visibility.

I’m confident I can deliver a complete and scalable test suite that aligns with OpenZeppelin’s standards and helps future-proof the contract for potential upgrades like burn-on-redeem.

Happy to get started if you assign me!

[Josue19-08]

Hello @aguilar1x ! I'd like to apply to implement the comprehensive test suite for the Promotion NFT Contract with OpenZeppelin's Stellar contracts. I'm waiting for PR #118 merge (#118) to start immediately. My plan includes creating exhaustive tests for all modules (mint.rs, redeem.rs, transfer.rs, roles.rs, metadata.rs, storage.rs, lib.rs) covering the 8 specified categories: initialization, role management, promotional minting logic, redemption system with timestamps, transfers with post-redemption restrictions, immutable metadata access, storage integrity, and complete event emission. I'll use soroban-sdk with mock accounts (admin, seller, buyer1, redeemer), edge case testing, and aim for complete coverage.

[DanielEmmanuel1]

Gm gm!

I'm Deon and I'm interested in taking up this issue. I have great experience with writing unit and integration tests for smart contracts, especially using the soroban-sdk and working with role-based access control, event emission, and NFT logic.

I'll structure the test modules (mint_tests, redeem_tests, etc.) as outlined and ensure coverage of all core behaviors, edge cases, and event validations. Mocks for accounts like admin, seller, and redeemer will be used to simulate real-world flows. I'll also make sure the tests are CI-friendly with clear assertions and logs.

I can get this done under the allocated completion time.
I am a fellowship contributor with great track record and will like to take up this issue

Recommended by OnlyDust for outstanding experience and quality contributions.

[pushkarm029]

I can complete this quickly. Thanks!

Recommended by OnlyDust for outstanding experience and quality contributions.

[JosueBrenes]

Can i work in this issue? please

Recommended by OnlyDust for exceptional experience, quality, and reliability.