You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Context: This repo already has api_v1_middleware.rs and api_deprecation_middleware.rs -- before adding ~15 new endpoints under /api/v1/... in this batch, worth confirming they actually route through that existing versioning/deprecation machinery instead of being wired up ad hoc.
Where you find an inconsistency, fix the registration rather than special-casing the middleware to accommodate it.
Watch out for:
This issue's value is in catching endpoints that got wired up ad hoc during a busy pivot -- don't rubber-stamp it, actually trace each route's registration code.
Definition of done:
All new endpoints confirmed to go through the same versioning/deprecation middleware as existing v1 routes, or a documented reason why not
Context: This repo already has
api_v1_middleware.rsandapi_deprecation_middleware.rs-- before adding ~15 new endpoints under/api/v1/...in this batch, worth confirming they actually route through that existing versioning/deprecation machinery instead of being wired up ad hoc.Where:
src/api_v1_middleware.rs,src/api_deprecation_middleware.rsWhat to do:
Suggested approach:
api_v1_middleware.rs/api_deprecation_middleware.rsthe same way pre-existing v1 routes are.Watch out for:
Definition of done: