Add Test for Factory Tracking Vault Count Correctly After Removals

[Jayy4rl]

Description

If the factory maintains a vault count, ensure it remains correct after adding and removing vaults.

Requirements

• In vault_factory tests, add a scenario that:
  • Creates multiple vaults
  • Removes one or more
  • Asserts the reported count and queries reflect the updated number

Definition of Done

• Vault count correctness after removals is tested
• No production logic changes
• cargo test -p vault_factory passes

[MarcusDavidG]

@MarcusDavidG has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

Gm, I'm Marcus David,

Applying to #192 Add Test for Factory Tracking Vault Count Correctly After Removals.

I have strong experience writing factory pattern tests in Soroban contracts, especially around add/remove tracking and count consistency.

Plan to deliver:

• Add a new test case in the vault_factory test suite.
• Create multiple vaults through the factory.
• Remove one or more vaults.
• Assert that the factory's reported vault count is accurate and reflects the updated number after removals.
• Verify that vault queries (e.g. get_vault or list_vaults) also return the correct updated state.
• Ensure the test introduces no changes to production logic and cargo test -p vault_factory passes cleanly.
• Keep the test focused and consistent with existing factory test patterns.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @MarcusDavidG to this issue.

[Majormaxx]

@Majormaxx has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

Hi Team, Can I tackle this? ETA is 4 hours

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Majormaxx to this issue.

[drips-wave]

Congratulations, @Majormaxx! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on March 30, 2026.

🧑‍💻 @Majormaxx: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊