Hardcoded `share_decimals: 6` in Factory Ignores Asset's Actual Decimals

[Jayy4rl]

Description

In vault_factory::_create_single_rwa_vault, the share_decimals field of InitParams is hardcoded to 6u32 with the comment // USDC convention. If a vault is created with a non-USDC asset (e.g., a token with 18 decimals like a wrapped ETH, or 8 decimals like BTC-pegged tokens), the share/asset ratio will be silently miscalculated by orders of magnitude.

Requirements

• Add a share_decimals: u32 field to CreateVaultParams / BatchVaultParams
• Pass it through to InitParams instead of hardcoding 6
• In create_single_rwa_vault (simple variant), default to 7u32 (SEP-41 convention) or require the caller to specify it as an additional parameter
• Document the relationship between asset decimals and share decimals

Key Files

• vault_factory/src/lib.rs — _create_single_rwa_vault (~L370)
• vault_factory/src/types.rs — BatchVaultParams, CreateVaultParams

Definition of Done

• share_decimals is configurable per vault
• No hardcoded 6u32 remains
• CreateVaultParams and BatchVaultParams include the new field
• Existing simple creation function uses a documented default

[Samaro1]

@Samaro1 has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

gm gm boss, I would love to work on this issue, I will provide a satisfactory and efficient PR in 12 hours tops

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Samaro1 to this issue.

[trinnode]

@trinnode has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

Hello Maintainer, I have gone through the description and understood it. Can you assign me this issue? Thank you

ℹ️ Repo Maintainers: To accept this application, review their application or assign @trinnode to this issue.

[drips-wave]

Congratulations, @trinnode! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on March 30, 2026.

🧑‍💻 @trinnode: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[HuiNeng6]

@HuiNeng6 has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

I can make share_decimals configurable per vault instead of hardcoded to 6. This requires updating the CreateVaultParams and BatchVaultParams types.

I have experience with Soroban smart contracts and Rust. Estimated completion: 24-48 hours after assignment.

[drips-wave]

This issue has been marked as completed by a Drips Wave moderator for @trinnode as part of the Stellar Wave Program's 3rd Wave 🥳

Moderator's reason: [Auto-assessed] The PR has been open for 6 days (well beyond the 24-hour threshold) without any maintainer objections. The contributor, who was assigned to the issue, has addressed all requirements including making share_decimals configurable, updating the batch/create parameters, and providing documentation as requested.

😎 @trinnode: You earned 150 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

ℹ️ Note: This issue was marked complete via moderation. Points were issued even though the GitHub issue remains open.