Description
apps/backend/tests/load/deployment-pipeline.load.test.ts runs concurrent deployments but the pass/fail thresholds (p95 latency, error rate) are not enforced — the test always passes. Define and enforce realistic SLO thresholds.
Requirements and context
- Must be secure, tested, and documented where applicable
- Should stay reviewable and fit the current monorepo structure
- Relevant files:
apps/backend/tests/load/deployment-pipeline.load.test.ts
Suggested execution
- Create branch:
issue-014-load-test-deployment-pipeline-thresholds
- Keep changes scoped to the issue and reference the task IDs in the PR
Implement changes
- Define SLO constants: p95 latency ≤ 3 s, error rate ≤ 1%, throughput ≥ 10 req/s
- Add assertions in
generateReport that fail the test when SLOs are breached
- Parameterise concurrency level via an env var so CI can run a lighter variant
Test and commit
- Run the load test locally and confirm thresholds are achievable
- Include the baseline report output in the PR description
- Note: thresholds are for the simulated pipeline, not production Vercel/GitHub APIs
Example commit message
test(load): enforce SLO thresholds in deployment pipeline load test
Guidelines
- Prefer small, reviewable PRs
- Keep naming and data contracts consistent with the spec docs
Description
apps/backend/tests/load/deployment-pipeline.load.test.tsruns concurrent deployments but the pass/fail thresholds (p95 latency, error rate) are not enforced — the test always passes. Define and enforce realistic SLO thresholds.Requirements and context
apps/backend/tests/load/deployment-pipeline.load.test.tsSuggested execution
issue-014-load-test-deployment-pipeline-thresholdsImplement changes
generateReportthat fail the test when SLOs are breachedTest and commit
Example commit message
Guidelines