Skip to content

New direction for SOS v4? #1

@syntroniks

Description

@syntroniks

I like where this repo is headed!

I have a suggestion for CMakeLists.txt that may be related to the comment in this macro --

macro(sdk_add_subdirectory NAME BRANCH)
clone_or_pull(${NAME} ssh://[email protected]/StratifyLabs/${NAME}.git ${BRANCH})
add_subdirectory(${BASE_DIRECTORY}/${NAME} ${NAME})
# include(${CMAKE_CURRENT_SOURCE_DIR}/../${NAME}/library/${NAME}.cmake)
endmacro()

I'd most likely be using forks of some of these libraries (potentially not on github). Perhaps as an alternative to sdk_add_subdirectory, we could use git submodules.

The advantage of sdk_add_subdirectory is pulling repos that are already cloned. I've used a submodule maintenance cmake script with some success: link here

Is this repo intended to be the next top-level? I could imagine forking and cloning this and having it bring in all dependencies (SOS, etc...) by way of submodules. Then building those via included cmake scripts rather than relying on the distributed toolchain.

Excited for v4!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions