Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExecuTorch 0.5.0 #8999

Closed
shoumikhin opened this issue Jan 30, 2025 · 5 comments
Closed

Add ExecuTorch 0.5.0 #8999

shoumikhin opened this issue Jan 30, 2025 · 5 comments
Labels
Add Package [Automatic PR]

Comments

@shoumikhin
Copy link

New Packages

https://github.com/pytorch/executorch/tree/swiftpm-0.5.0

@shoumikhin shoumikhin added the Add Package [Automatic PR] label Jan 30, 2025
Copy link
Contributor

It looks like there’s nothing to do here!

The package may already be in the package list or on the denylist. Or, if you submitted the wrong URL or there’s a typo, please close this issue and start a new one.

Validate Error: url not found (404): https://api.github.com/repos/tree/swiftpm-0.5.0

@finestructure
Copy link
Member

Thanks for the submission but unfortunately we only support repositories with the package manifest (Package.swift) at the top level of the repository!

@shoumikhin
Copy link
Author

@finestructure the package is at the top level but on a different branch :)

ExecuTorch is distributed as a collection of prebuilt .xcframework binaries that SwiftPM downloads and uses directly. To avoid unnecessary downloads of the full code repository, including submodules - saving both time and disk space - ExecuTorch maintains separate branches for each version. These branches contain only the necessary package files and reference an S3 bucket for downloading the actual binaries.

For example: https://github.com/pytorch/executorch/tree/swiftpm-0.5.0 More details can be found in the documentation https://pytorch.org/executorch/0.5/apple-runtime.html

In context of versioning, we release stable versions approximately quarterly. If it were possible to point to a specific branch instead of main, we would simply add a new package pointing to the swiftpm-0.6.0 branch for the next release, and so on.

A potential workaround could be creating a separate repository, but it would only contain the Package.swift file - just like the version-specific branches. We’re not sure if we plan to maintain a separate repository under the PyTorch organization solely for this purpose.

So, I’m curious would it be possible to add a package to the Swift Package Index that points to a branch other than main? How feasible would it be to support such a setup in the future?

@finestructure
Copy link
Member

Yes, I've just caught up on Discord and seen your message there now :)

I'm afraid we have to rely on Github's default branch pointer to figure out which branch we need to "bless" as the main development branch.

If creating a separate repository doesn't work well for you, would changing the GH default branch pointer upon release potentially be feasible?

@finestructure
Copy link
Member

If creating a separate repository doesn't work well for you, would changing the GH default branch pointer upon release potentially be feasible?

Ah no - this is a dev repo, so that won't work without impacting everyone. I thought it might be a repo for release packaging where this might be feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add Package [Automatic PR]
Projects
None yet
Development

No branches or pull requests

2 participants