Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The example counter does not finish a simulation #9

Open
jmartori opened this issue Oct 19, 2015 · 4 comments
Open

The example counter does not finish a simulation #9

jmartori opened this issue Oct 19, 2015 · 4 comments

Comments

@jmartori
Copy link
Contributor

Son of Issue #6. After making the code run again it doesn't seem to finish a simulation, even after a generous amount of time.

@jmartori
Copy link
Contributor Author

It seems that it should be the simulation.gracetime the one that limits the max time of the simulation or simulation.cycles but none of them seem to fix it. (and modifing simulation.cycles from the config file, crashes the simulation)

@jmartori
Copy link
Contributor Author

Ignored operations size and just check boolean of hasMoreOperations to setEndTime

In order to fix the never ending simulation problem I added in the function loadClientOperations in the file DCDataStoreSimulator.java a check that the return from hasMoreOperations, where it already check if there are more operations to process, and in case of being null I setEndTime.

This may cause other problems thats was why Joao had set the check to the number of operations being equal to zero. But as it is right now both simulation (counter and moodle logic) finish at what seems to be the right time.

@bieniusa
Copy link

You know that you can edit your comments to keep the overall number small?

@jmartori
Copy link
Contributor Author

I had no idea. But I was moving them from BitBucket to have them in the same order of messages that we had them back there. (But now I see that maybe a summary of what we had there would have been better...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants