-
Notifications
You must be signed in to change notification settings - Fork 0
[ENG-2210][ENG-2200] synd-cli #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
daniilrrr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dumb q but are there any low time commitment/ "low-hanging fruit" approaches we could take to validating that create-chain works in CI and that a new PR hasn't broken it? Would prefer to know proactively if create-chain works vs finding out in a a deployment or from a customer. It doesn't have to be super comprehensive but even checking if things like if new lib/tooling/contract versions have broken something would be helpful to reduce the feedback loop
separate question - is there a release artifact that gets produced for synd-cli "releases" like we produce Docker containers for the other services? Maybe something like a bun executable? If so, I think we should have a Github action for that to create it as part of the release flow
| functionName: "bridgeCreator" | ||
| }) | ||
|
|
||
| // v3.1 - bridge, sequencerInbox, delayBufferableSequencerInbox, inbox, rollupEventInbox, outbox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any way we can assert or unit test this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will follow up with tests in an additional PR so this one does not get unwieldy, ty!
Yup totally - We currently cover this with 2 GH actions. 1 to make sure the ABIs the CLI uses are up to date with the source code (similar to how we check the contract bindings for the portions of the stack where we utilize rust & go). & another that typechecks the CLI. If the ABIs are out of sync the first action fails. If the ABIs are in sync but the cli code hasn't been updated yet, the 2 action will fail. Added support for publishing builds in 4d600636! |
ericvelazquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Ticket
What does this PR do?
RollupCreator.createRollup()to only pass required fields for Syndicate Appchains (no validators, batch posters, batch post manager, or fee token pricer)--config path_to_options.jsonbun synd-cli <cmmd> init(bun synd-cli appchain create foundation initwill write an example config file tooptions/foundation.json)Breaking changes?
Anything interesting?
How can this PR be tested?
bun synd-cli -h