(gpu) change code convention

Author: Arthapz

.clang-format

@@ -23,13 +23,22 @@ BitFieldColonSpacing: After
 BreakBeforeConceptDeclarations: 'true'
 BreakBinaryOperations: RespectPrecedence
 EmptyLineBeforeAccessModifier: LogicalBlock
+EnumTrailingComma: Insert
+FixNamespaceComments: 'true'
 IndentExternBlock: Indent
 IndentGotoLabels: 'false'
 IndentRequiresClause: 'true'
 InsertBraces: 'false'
 InsertTrailingCommas: Wrapped
 LambdaBodyIndentation: Signature
 PPIndentWidth: 4
+PenaltyBreakAssignment: 1000
+PenaltyReturnTypeOnItsOwnLine: 1000
+PenaltyBreakBeforeFirstCallParameter: 1000
+PenaltyBreakOpenParenthesis: 1000
+PenaltyBreakBeforeMemberAccess: 10
+PenaltyIndentedWhitespace: 1
+ContinuationIndentWidth: 2
 ReferenceAlignment: Left
 # RemoveBracesLLVM: 'true'
 RequiresClausePosition: OwnLine
@@ -40,9 +49,18 @@ SpaceBeforeCaseColon: 'false'
 AlwaysBreakAfterDefinitionReturnType: None
 SpaceBeforeSquareBrackets: 'false'
 SpaceInEmptyBlock: 'false'
-AttributeMacros: [STORMKIT_FORCE_INLINE, STORMKIT_API, STORMKIT_PRIVATE, STORMKIT_PUBLIC]
+AttributeMacros: [STORMKIT_FORCE_INLINE, STORMKIT_API, STORMKIT_PRIVATE, STORMKIT_PUBLIC, STORMKIT_CONST, STORMKIT_PURE, STORMKIT_INTRINSIC]
 IfMacros: [CASE_DO, CASE_DO_RETURN, CASE, CASE_ARGS_DO]
 BreakAfterAttributes: Always
+Macros:
+  - STORMKIT_FORCE_INLINE=[[maybe_unused]]
+  - STORMKIT_API=[[maybe_unused]]
+  - STORMKIT_PRIVATE=[[maybe_unused]]
+  - STORMKIT_PUBLIC=[[maybe_unused]]
+  - STORMKIT_CONST=[[maybe_unused]]
+  - STORMKIT_PURE=[[maybe_unused]]
+  - STORMKIT_INTRINSIC=[[maybe_unused]]
+  
 QualifierAlignment: Custom
 QualifierOrder: [static, inline, volatile, restrict, constexpr, const, type]
 
@@ -64,7 +82,6 @@ ColumnLimit: '100'
 CompactNamespaces: 'true'
 ConstructorInitializerAllOnOneLineOrOnePerLine: 'false'
 ConstructorInitializerIndentWidth: '4'
-ContinuationIndentWidth: '4'
 IncludeBlocks: Preserve
 IndentCaseLabels: 'true'
 IndentWidth: '4'
@@ -76,7 +93,6 @@ MaxEmptyLinesToKeep: '1'
 NamespaceIndentation: All
 ObjCSpaceAfterProperty: true
 ObjCSpaceBeforeProtocolList: false
-PenaltyBreakAssignment: '0'
 PointerAlignment: Left
 SortIncludes: 'true'
 SortUsingDeclarations: 'true'
@@ -91,7 +107,6 @@ SpacesInAngles: 'false'
 Standard: c++20
 TabWidth: '4'
 UseTab: Never
-PenaltyBreakBeforeFirstCallParameter: '120'
 ---
 Language: ObjC
 AlignAfterOpenBracket: Align
@@ -137,8 +152,12 @@ MaxEmptyLinesToKeep: '1'
 NamespaceIndentation: All
 ObjCSpaceAfterProperty: true
 ObjCSpaceBeforeProtocolList: false
-PenaltyBreakAssignment: '0'
 PointerAlignment: Right
+PenaltyBreakAssignment: 1000
+PenaltyReturnTypeOnItsOwnLine: 1000
+PenaltyBreakBeforeFirstCallParameter: 1000
+PenaltyBreakOpenParenthesis: 1000
+PenaltyBreakBeforeMemberAccess: 10
 SortIncludes: 'true'
 SortUsingDeclarations: 'true'
 SpaceAfterTemplateKeyword: 'false'
@@ -152,7 +171,6 @@ SpacesInAngles: 'false'
 Standard: c++20
 TabWidth: '4'
 UseTab: Never
-PenaltyBreakBeforeFirstCallParameter: '120'
 PenaltyIndentedWhitespace: '1'
 QualifierAlignment: Custom
 QualifierOrder: [static, inline, volatile, restrict, constexpr, const, type]

.github/workflows/Linux.yml

@@ -79,6 +79,7 @@ jobs:
               libelf-dev
               libdwarf-dev
               mold
+              nasm
               llvm${{ env.LLVM_VERSION }}
               llvm${{ env.LLVM_VERSION }}-dev
               llvm${{ env.LLVM_VERSION }}-runtime
@@ -123,7 +124,7 @@ jobs:
       - name: Setup XMake
         uses: xmake-io/github-action-setup-xmake@v1
         with:
-          xmake-version: Arthapz/xmake#branch@improve-jobgraph-support2
+          xmake-version: branch@dev
           actions-cache-folder: .xmake-cache
 
       - name: Cache XMake

.github/workflows/Windows.yml

@@ -82,7 +82,7 @@ jobs:
         if: ${{ !steps.restore-xmakecache.outputs.cache-hit }}
         uses: xmake-io/github-action-setup-xmake@v1
         with:
-          xmake-version: Arthapz/xmake#branch@fix-cmake-clang-msstl
+          xmake-version: branch@dev
           actions-cache-folder: '.xmake-cache'
 
       - name: Cache XMake

.github/workflows/macOS.yml

@@ -49,7 +49,7 @@ jobs:
       - name: Install build tools
         uses: tecolicom/actions-use-homebrew-tools@v1
         with:
-          tools: llvm ninja meson mold
+          tools: llvm ninja meson mold nasm pkgconf
           verbose: true
 
       - name: Checkout
@@ -78,7 +78,7 @@ jobs:
       - name: Setup XMake
         uses: xmake-io/github-action-setup-xmake@v1
         with:
-          xmake-version: Arthapz/xmake#branch@improve-jobgraph-support2
+          xmake-version: branch@dev
           actions-cache-folder: .xmake-cache
 
       - name: Cache XMake

src/Gpu/Execution/CommandPool.cpp renamed to backup-src/execution/command_pool.cpp

@@ -2,13 +2,13 @@
 // This file is subject to the license terms in the LICENSE file
 // found in the top-level of this distribution
 
-module stormkit.Gpu;
+module stormkit.gpu;
 
 import std;
 
 import stormkit.core;
 
-import stormkit.Gpu.Vulkan;
+import stormkit.gpu.vulkan;
 import :Core;
 import :Execution.CommandBuffer;
 
@@ -17,7 +17,7 @@ using namespace std::literals;
 namespace stormkit::gpu {
     /////////////////////////////////////
     /////////////////////////////////////
-    auto CommandPool::createVkCommandBuffers(const Device&      device,
+    auto CommandPool::create_vk_command_buffers(const Device&      device,
                                              RangeExtent        count,
                                              CommandBufferLevel level) const noexcept
         -> std::vector<vk::raii::CommandBuffer> {
@@ -44,13 +44,13 @@ namespace stormkit::gpu {
 
         if (create_count > 0) {
             const auto allocate_info
-                = vk::CommandBufferAllocateInfo { .commandPool = *vkHandle(),
+                = vk::CommandBufferAllocateInfo { .commandPool = *native_handle(),
                                                   .level = narrow<vk::CommandBufferLevel>(level),
                                                   .commandBufferCount = as<UInt32>(count) };
 
             // TODO handle error here
-            std::ranges::move(device.vkHandle()
-                                  .allocateCommandBuffers(allocate_info)
+            std::ranges::move(device.native_handle()
+                                  .allocate_command_buffers(allocate_info)
                                   .transform_error(core :.monadic::assert(
                                       std::format("Failed to allocate {} command buffers",
                                                   create_count)))

src/Gpu/Execution/Pipeline.cpp renamed to backup-src/execution/pipeline.cpp

@@ -2,22 +2,22 @@
 // This file is subject to the license terms in the LICENSE file
 // found in the top-level of this distribution
 
-module stormkit.Gpu;
+module stormkit.gpu;
 
 import std;
 
 import stormkit.core;
 
-import stormkit.Gpu.Vulkan;
+import stormkit.gpu.vulkan;
 import :Core;
 import :Execution.Pipeline;
 import :Execution.RenderPass;
-import :Execution.RasterPipelineState;
+import execution.raster_pipeline;
 
 namespace stormkit::gpu {
     /////////////////////////////////////
     /////////////////////////////////////
-    auto Pipeline::doInitRasterPipeline(const Device&                    device,
+    auto Pipeline::do_init(const Device&                    device,
                                         const PipelineLayout&            layout,
                                         const RenderPass&                render_pass,
                                         OptionalRef<const PipelineCache> pipeline_cache) noexcept
@@ -68,14 +68,14 @@ namespace stormkit::gpu {
                                | std::ranges::to<std::vector>();
 
         const auto viewport_state =
-            vk::PipelineViewportStateCreateInfo {}.setViewports(viewports).setScissors(scissors);
+            vk::PipelineViewportStateCreateInfo {}.set_viewports(viewports).set_scissors(scissors);
 
         const auto rasterizer =
             vk::PipelineRasterizationStateCreateInfo {
                 .depthClampEnable = state.rasterization_state.depth_clamp_enable,
                 .rasterizerDiscardEnable = state.rasterization_state.rasterizer_discard_enable,
                 .polygonMode = narrow<vk::PolygonMode>(state.rasterization_state.polygon_mode),
-                .cullMode = toVkFlags<vk::CullModeFlagBits>(state.rasterization_state.cull_mode),
+                .cullMode = to_vkflags<vk::CullModeFlagBits>(state.rasterization_state.cull_mode),
                 .frontFace = narrow<vk::FrontFace>(state.rasterization_state.front_face),
                 .lineWidth = state.rasterization_state.line_width
             };
@@ -97,7 +97,7 @@ namespace stormkit::gpu {
                     .srcAlphaBlendFactor = narrow<vk::BlendFactor>(attachment.src_alpha_blend_factor),
                     .dstAlphaBlendFactor = narrow<vk::BlendFactor>(attachment.dst_alpha_blend_factor),
                     .alphaBlendOp        = narrow<vk::BlendOp>(attachment.alpha_blend_operation),
-                    .colorWriteMask      = toVkFlags<vk::ColorComponentFlagBits>(attachment.color_write_mask)
+                    .colorWriteMask      = to_vkflags<vk::ColorComponentFlagBits>(attachment.color_write_mask)
                 };
             })
             | std::ranges::to<std::vector>();
@@ -106,7 +106,7 @@ namespace stormkit::gpu {
                 .logicOpEnable  = state.color_blend_state.logic_operation_enable,
                 .logicOp        = narrow<vk::LogicOp>(state.color_blend_state.logic_operation),
         }
-        .setBlendConstants({ state.color_blend_state.blend_constants[0],
+        .set_blend_constants({ state.color_blend_state.blend_constants[0],
                              state.color_blend_state.blend_constants[1],
                              state.color_blend_state.blend_constants[2],
                              state.color_blend_state.blend_constants[3] })
@@ -124,7 +124,7 @@ namespace stormkit::gpu {
                                  static constexpr auto NAME = "main";
                                  return vk::PipelineShaderStageCreateInfo {
                                      .stage  = narrow<vk::ShaderStageFlagBits>(shader->type()),
-                                     .module = toVkHandle(shader),
+                                     .module = to_vkhandle(shader),
                                      .pName  = NAME
                                  };
                              })
@@ -149,8 +149,8 @@ namespace stormkit::gpu {
          .pDepthStencilState  = &depth_stencil,
          .pColorBlendState    = &color_blending,
          .pDynamicState       = &dynamic_state,
-         .layout              = toVkHandle(layout),
-         .renderPass          = toVkHandle(render_pass),
+         .layout              = to_vkhandle(layout),
+         .renderPass          = to_vkhandle(render_pass),
          .subpass             = 0,
          .basePipelineHandle  = nullptr,
          .basePipelineIndex   = -1

src/Gpu/Execution/PipelineCache.cpp renamed to backup-src/execution/pipeline_cache.cpp

@@ -2,7 +2,7 @@
 // This file is subject to the license terms in the LICENSE file
 // found in the top-level of this distribution
 
-module stormkit.Gpu;
+module stormkit.gpu;
 
 import std;
 
@@ -11,17 +11,17 @@ import stormkit.log;
 
 #include <stormkit/log/log_macro.hpp>
 
-import stormkit.Gpu.Vulkan;
+import stormkit.gpu.vulkan;
 import :Core;
 import :Execution.Pipeline;
 
 namespace stormkit::gpu {
-    LOGGER("stormkit.Gpu")
+    LOGGER("stormkit.gpu")
 
     /////////////////////////////////////
     /////////////////////////////////////
-    auto PipelineCache::createNewPipelineCache(const Device& device) -> VulkanExpected<void> {
-        const auto physical_device_infos = device.physicalDevice().info();
+    auto PipelineCache::create_new_pipeline_cache(const Device& device) -> VulkanExpected<void> {
+        const auto physical_device_infos = device.physical_device().info();
 
         m_serialized.guard.magic     = MAGIC;
         m_serialized.guard.data_size = 0u;
@@ -34,7 +34,7 @@ namespace stormkit::gpu {
         std::ranges::copy(physical_device_infos.pipeline_cache_uuid,
                           std::ranges::begin(m_serialized.uuid.value));
 
-        return device.vkHandle()
+        return device.native_handle()
             .createPipelineCache({})
             .transform(core :.monadic::set(m_vk_pipeline_cache))
             .transform([this] noexcept -> void {
@@ -44,8 +44,8 @@ namespace stormkit::gpu {
 
     /////////////////////////////////////
     /////////////////////////////////////
-    auto PipelineCache::readPipelineCache(const Device& device) -> VulkanExpected<void> {
-        const auto physical_device_infos = device.physicalDevice().info();
+    auto PipelineCache::read_pipeline_cache(const Device& device) -> VulkanExpected<void> {
+        const auto physical_device_infos = device.physical_device().info();
 
         auto stream = std::ifstream { m_path.string(), std::ios::binary };
         read(stream, as_bytes(m_serialized.guard));
@@ -57,46 +57,46 @@ namespace stormkit::gpu {
                  m_serialized.guard.magic,
                  MAGIC);
 
-            return createNewPipelineCache(device);
+            return create_new_pipeline_cache(device);
         }
 
         if (m_serialized.infos.version != VERSION) {
             elog("Mismatch pipeline cache version, have {}, expected: {}",
                  m_serialized.infos.version,
                  VERSION);
 
-            return createNewPipelineCache(device);
+            return create_new_pipeline_cache(device);
         }
 
         if (m_serialized.infos.vendor_id != physical_device_infos.vendor_id) {
             elog("Mismatch pipeline cache vendor id, have {:#06x}, expected: {:#06x}",
                  m_serialized.infos.vendor_id,
                  physical_device_infos.vendor_id);
 
-            return createNewPipelineCache(device);
+            return create_new_pipeline_cache(device);
         }
 
         if (m_serialized.infos.device_id != physical_device_infos.device_id) {
             elog("Mismatch pipeline cache device id, have {:#06x}, expected: {:#06x}",
                  m_serialized.infos.device_id,
                  physical_device_infos.device_id);
 
-            return createNewPipelineCache(device);
+            return create_new_pipeline_cache(device);
         }
 
         if (!std::equal(std::cbegin(m_serialized.uuid.value),
                         std::cend(m_serialized.uuid.value),
                         std::cbegin(physical_device_infos.pipeline_cache_uuid))) {
             elog("Mismatch pipeline cache device UUID");
 
-            return createNewPipelineCache(device);
+            return create_new_pipeline_cache(device);
         }
 
         const auto data = read(stream, m_serialized.guard.data_size);
 
         const auto create_info = vk::PipelineCacheCreateInfo {}.setInitialData<Byte>(data);
 
-        return device.vkHandle()
+        return device.native_handle()
             .createPipelineCache(create_info)
             .transform(core :.monadic::set(m_vk_pipeline_cache))
             .transform([this]() noexcept -> void {
@@ -107,7 +107,7 @@ namespace stormkit::gpu {
 
     /////////////////////////////////////
     /////////////////////////////////////
-    auto PipelineCache::saveCache() -> void {
+    auto PipelineCache::save_cache() -> void {
         auto data                    = m_vk_pipeline_cache->getData();
         m_serialized.guard.data_size = std::size(data);
         m_serialized.guard.data_hash = 0u;