Skip to content

Commit 3755745

Browse files
committed
Remove all macOS GCC support - use Clang only on macOS
1 parent 31855d8 commit 3755745

File tree

1 file changed

+4
-20
lines changed

1 file changed

+4
-20
lines changed

.github/workflows/build_node_shared.yml

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,7 @@ jobs:
4444
lib_name: libnode.so.127
4545
nproc_cmd: nproc
4646
# macOS x64 builds
47-
- os: macos-13
48-
platform: mac
49-
arch: x64
50-
compiler: gcc
51-
container: ""
52-
lib_name: libnode.127.dylib
53-
nproc_cmd: sysctl -n hw.ncpu
47+
# Note: macOS should use Clang (Apple's official toolchain), GCC has compatibility issues
5448
- os: macos-13
5549
platform: mac
5650
arch: x64
@@ -59,7 +53,7 @@ jobs:
5953
lib_name: libnode.127.dylib
6054
nproc_cmd: sysctl -n hw.ncpu
6155
# macOS ARM64 builds
62-
# Note: GCC is not supported on Apple Silicon, only Clang is available
56+
# Note: Apple Silicon only supports Clang
6357
- os: macos-14
6458
platform: mac
6559
arch: arm64
@@ -93,21 +87,11 @@ jobs:
9387
with:
9488
python-version: '3.11'
9589

96-
- name: Install GCC (macOS)
97-
if: matrix.platform == 'mac' && matrix.compiler == 'gcc'
98-
run: |
99-
brew install gcc@13
100-
echo "CC=$(brew --prefix gcc@13)/bin/gcc-13" >> $GITHUB_ENV
101-
echo "CXX=$(brew --prefix gcc@13)/bin/g++-13" >> $GITHUB_ENV
102-
10390
- name: Configure and Build
10491
run: |
10592
if [ "${{ matrix.compiler }}" = "gcc" ]; then
106-
# CC and CXX already set for macOS GCC via GITHUB_ENV
107-
if [ "${{ matrix.platform }}" != "mac" ]; then
108-
export CC=gcc
109-
export CXX=g++
110-
fi
93+
export CC=gcc
94+
export CXX=g++
11195
else
11296
export CC=clang
11397
export CXX=clang++

0 commit comments

Comments
 (0)