Skip to content

Commit 63c50b0

Browse files
authored
Merge pull request #466 from TNRIS/lh/deprecation
Deprecate Datahub Orders. Therefore change 'new orders' to just 'ord…
2 parents 4a534f9 + e39ccd0 commit 63c50b0

File tree

5 files changed

+24
-141
lines changed

5 files changed

+24
-141
lines changed

src/data_hub/contact/admin.py

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
Campaign,
1313
CampaignSubscriber,
1414
DataHubContact,
15-
DataHubOrder,
1615
OrderType,
1716
OrderDetailsType,
1817
DataHubOutsideEntityContact,
@@ -301,28 +300,6 @@ def save_model(self, request, obj, form, change):
301300
super().save_model(request, obj, form, change)
302301
def response_change(self, request, obj):
303302
return redirect('/admin/contact/orderdetailstype/' + str(obj.id) + '/change/')
304-
@admin.register(DataHubOrder)
305-
class DataHubOrderAdmin(admin.ModelAdmin, ExportSelectedToCsvMixin):
306-
model = DataHubOrder
307-
actions = ["export_selected_to_csv"]
308-
list_display = (
309-
'name',
310-
'email',
311-
'phone',
312-
'address',
313-
'organization',
314-
'industry',
315-
'harddrive',
316-
'delivery',
317-
'payment',
318-
'created'
319-
)
320-
ordering = ('-created',)
321-
322-
def get_readonly_fields(self, request, obj=None):
323-
if obj:
324-
self.readonly_fields = [field.name for field in obj.__class__._meta.fields]
325-
return self.readonly_fields
326303

327304

328305
@admin.register(DataHubOutsideEntityContact)
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# Generated by Django 4.2.15 on 2025-08-05 12:45
2+
3+
from django.db import migrations
4+
5+
6+
class Migration(migrations.Migration):
7+
8+
dependencies = [
9+
('contact', '0055_alter_emailtemplate_serializer_classname'),
10+
]
11+
12+
operations = [
13+
migrations.DeleteModel(
14+
name='DataHubOrder',
15+
),
16+
migrations.AlterModelOptions(
17+
name='ordertype',
18+
options={'verbose_name': 'DataHub Order', 'verbose_name_plural': 'DataHub Orders'},
19+
),
20+
]

src/data_hub/contact/models.py

Lines changed: 2 additions & 95 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ class OrderType(models.Model):
5959

6060
class Meta:
6161
db_table = 'order_type'
62-
verbose_name = 'DataHub New Order'
63-
verbose_name_plural = 'DataHub New Orders'
62+
verbose_name = 'DataHub Order'
63+
verbose_name_plural = 'DataHub Orders'
6464
constraints = [
6565
models.CheckConstraint(
6666
name="%(app_label)s_%(class)s_order_approved_constraint",
@@ -334,99 +334,6 @@ class Meta:
334334
def __str__(self):
335335
return self.name + " " + self.created.strftime('%Y-%m-%d %H:%M')
336336

337-
class DataHubOrder(models.Model):
338-
"""
339-
DataHub order cart form on data.tnris.org (Dataset Order)
340-
https://data.tnris.org/cart/
341-
"""
342-
343-
class Meta:
344-
db_table = 'contact_datahub_order'
345-
verbose_name = 'DataHub Order'
346-
verbose_name_plural = 'DataHub Orders'
347-
348-
datahub_order_id = models.UUIDField(
349-
'DataHub Order ID',
350-
primary_key=True,
351-
default=uuid.uuid4,
352-
editable=False
353-
)
354-
name = models.CharField(
355-
'Name',
356-
max_length=150,
357-
null=True,
358-
blank=True
359-
)
360-
email = models.CharField(
361-
'Email',
362-
max_length=150,
363-
null=True,
364-
blank=True
365-
)
366-
phone = models.CharField(
367-
'Phone',
368-
max_length=20,
369-
null=True,
370-
blank=True
371-
)
372-
address = models.CharField(
373-
'Address',
374-
max_length=250,
375-
null=True,
376-
blank=True
377-
)
378-
organization = models.CharField(
379-
'Organization',
380-
max_length=60,
381-
null=True,
382-
blank=True
383-
)
384-
industry = models.CharField(
385-
'Industry',
386-
max_length=50,
387-
null=True,
388-
blank=True
389-
)
390-
harddrive = models.CharField(
391-
'Hard Drive',
392-
max_length=50,
393-
null=True,
394-
blank=True
395-
)
396-
delivery = models.CharField(
397-
'Delivery Method',
398-
max_length=50,
399-
null=True,
400-
blank=True
401-
)
402-
payment = models.CharField(
403-
'Payment',
404-
max_length=50,
405-
null=True,
406-
blank=True
407-
)
408-
notes = models.TextField(
409-
'Notes',
410-
null=True,
411-
blank=True
412-
)
413-
order = models.TextField(
414-
'Order',
415-
null=True,
416-
blank=True
417-
)
418-
created = models.DateTimeField(
419-
'Created',
420-
auto_now_add=True
421-
)
422-
last_modified = models.DateTimeField(
423-
'Last Modified',
424-
auto_now=True
425-
)
426-
427-
def __str__(self):
428-
return self.name + " " + self.created.strftime('%Y-%m-%d %H:%M')
429-
430337
class DataHubOutsideEntityContact(models.Model):
431338
"""
432339
DataHub contact form on data.tnris.org outside entity cards (Outside Entity Data Inquiry)

src/data_hub/contact/serializers.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
Campaign,
55
CampaignSubscriber,
66
DataHubContact,
7-
DataHubOrder,
87
DataHubOutsideEntityContact,
98
EducationContact,
109
ForumJobBoardSubmission,
@@ -27,12 +26,6 @@ class Meta:
2726
fields = ('__all__')
2827

2928

30-
class DataHubOrderSerializer(serializers.ModelSerializer):
31-
class Meta:
32-
model = DataHubOrder
33-
fields = ('__all__')
34-
35-
3629
class DataHubOutsideEntityContactSerializer(serializers.ModelSerializer):
3730
class Meta:
3831
model = DataHubOutsideEntityContact

src/data_hub/contact/viewsets.py

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
from .models import CampaignSubscriber, SurveyTemplate
2121
from .serializers import (
2222
SurveyTemplateSerializer,
23-
DataHubOrderSerializer,
2423
CampaignSubscriberSerializer)
2524

2625
logger = logging.getLogger("errLog")
@@ -467,23 +466,10 @@ class DataHubOrdersViewSet(viewsets.ReadOnlyModelViewSet):
467466
Retrieve TxGIO DataHub Order submissions
468467
"""
469468
permission_classes = (IsAuthenticated,)
470-
serializer_class = DataHubOrderSerializer
471469
http_method_names = ['get']
472470

473-
def get_queryset(self):
474-
args = {}
475-
null_list = ['null', 'Null', 'none', 'None']
476-
# create argument object of query clauses
477-
for field in self.request.query_params.keys():
478-
if field != 'limit' and field != 'offset':
479-
value = self.request.query_params.get(field)
480-
# convert null queries
481-
if value in null_list:
482-
value = None
483-
args[field] = value
484-
# get records using query
485-
queryset = DataHubOrder.objects.filter(**args)
486-
return queryset
471+
def get(self):
472+
return Response("Endpoint deprecated", status=status.HTTP_410_GONE)
487473

488474
# Campaigns rw endpoint
489475
class SubmitCampaignSubscriptionViewSet(viewsets.GenericViewSet, mixins.CreateModelMixin):

0 commit comments

Comments
 (0)