Commit cef5a42
authored
[BUGFIX]: Fix all-documentations-menu versions, positioning and UX on mobile devices (#780)
1. **Fix versions not being displayed in the menu**
- BEFORE:

- AFTER:

2. **Fix stretched-link anchor tags being rendered over the menu**
Due to implementation of Bootstrap's `stretched-link` class, anchor tags
were rendered over all-documentations-menu popover window, making them
clickable through the menu's background. Managed to fix this by
unsetting the z-index of such anchor tags which got rid of the problem,
and it seems that no cards were negatively impacted by this change (user
is still able to click anywhere within the card)
3. **Fix visible height on mobile devices**
On mobile devices the menu was partially covered by the floating button.
In order to fix this, I've reduced the max height of the popover window
and made it scrollable on mobile, now the menu shouldn't be covered by
the button and I think this change is good for UX on mobile, as now user
is certain that he is scrolling through a menu (previously to see all
links within the menu, the whole page would be scrolled)
- BEFORE:

- AFTER (notice the scrollbar thumb on the right hand-side of popver
menu):
1 parent 54382a4 commit cef5a42
File tree
6 files changed
+19
-5
lines changed- packages/typo3-docs-theme
- assets
- js
- sass
- components
- resources/public
- css
- js
6 files changed
+19
-5
lines changedLines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
| 108 | + | |
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| |||
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
43 | 45 | | |
44 | 46 | | |
45 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23415 | 23415 | | |
23416 | 23416 | | |
23417 | 23417 | | |
| 23418 | + | |
| 23419 | + | |
| 23420 | + | |
| 23421 | + | |
23418 | 23422 | | |
23419 | 23423 | | |
23420 | 23424 | | |
| |||
24867 | 24871 | | |
24868 | 24872 | | |
24869 | 24873 | | |
| 24874 | + | |
| 24875 | + | |
24870 | 24876 | | |
24871 | 24877 | | |
24872 | 24878 | | |
| |||
24927 | 24933 | | |
24928 | 24934 | | |
24929 | 24935 | | |
24930 | | - | |
| 24936 | + | |
24931 | 24937 | | |
24932 | 24938 | | |
24933 | 24939 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments