Skip to content

Commit f454947

Browse files
committed
[BUGFIX] Allow required: false in confvals
Resolves #554
1 parent 7703c5d commit f454947

File tree

10 files changed

+16
-61
lines changed

10 files changed

+16
-61
lines changed

Documentation-rendertest/Confval/Index.rst

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,16 @@ Source:
3939
4040
.. confval:: mr_pommeroy
4141
:Default: Happy new year, Sophie!
42-
:type: shy
42+
:required: false
43+
:type: shy
4344
4445
Participant of Miss Sophie's birthday party.
4546
4647
Result:
4748

4849
.. confval:: mr_pommeroy
4950
:type: shy
51+
:required: false
5052
:Default: Happy new year, Sophie!
5153

5254
Participant of Miss Sophie's birthday party.
@@ -65,6 +67,7 @@ Adapted from the TypoScript Reference Manual:
6567

6668
.. confval:: align
6769
:type: align
70+
:required:
6871
:Default: left
6972
:Possible: \left | \center \| right
7073

composer.lock

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/Integration/tests/confval/confval-basic/expected/index.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ <h1>Confval<a class="headerlink" href="#confval" data-bs-toggle="modal" data-bs-
1111
<dt class="field-even">Type</dt>
1212
<dd class="field-even">string
1313
</dd>
14-
<dt class="field-odd">Required</dt>
15-
<dd class="field-odd"><p>true</p>
16-
</dd>
1714
<dt class="field-odd">Default</dt>
1815
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
1916
</dd>

tests/Integration/tests/confval/confval-duplicate-with-name/expected/anotherDomain.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ <h1>Confval in another domain<a class="headerlink" href="#confval-in-another-dom
1111
<dt class="field-even">Type</dt>
1212
<dd class="field-even">string
1313
</dd>
14-
<dt class="field-odd">Required</dt>
15-
<dd class="field-odd"><p>true</p>
16-
</dd>
1714
<dt class="field-odd">Default</dt>
1815
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
1916
</dd>

tests/Integration/tests/confval/confval-duplicate-with-name/expected/index.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ <h1>Confval<a class="headerlink" href="#confval" data-bs-toggle="modal" data-bs-
1111
<dt class="field-even">Type</dt>
1212
<dd class="field-even">string
1313
</dd>
14-
<dt class="field-odd">Required</dt>
15-
<dd class="field-odd"><p>true</p>
16-
</dd>
1714
<dt class="field-odd">Default</dt>
1815
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
1916
</dd>

tests/Integration/tests/confval/confval-duplicate/expected/anotherDomain.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ <h1>Confval in another domain<a class="headerlink" href="#confval-in-another-dom
1111
<dt class="field-even">Type</dt>
1212
<dd class="field-even">string
1313
</dd>
14-
<dt class="field-odd">Required</dt>
15-
<dd class="field-odd"><p>true</p>
16-
</dd>
1714
<dt class="field-odd">Default</dt>
1815
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
1916
</dd>

tests/Integration/tests/confval/confval-duplicate/expected/index.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ <h1>Confval<a class="headerlink" href="#confval" data-bs-toggle="modal" data-bs-
1111
<dt class="field-even">Type</dt>
1212
<dd class="field-even">string
1313
</dd>
14-
<dt class="field-odd">Required</dt>
15-
<dd class="field-odd"><p>true</p>
16-
</dd>
1714
<dt class="field-odd">Default</dt>
1815
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
1916
</dd>

tests/Integration/tests/confval/confval-menu-tree/expected/index.html

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -609,9 +609,6 @@ <h2>Confvals<a class="headerlink" href="#confvals" data-bs-toggle="modal" data-b
609609
<dt class="field-even">Type</dt>
610610
<dd class="field-even">string
611611
</dd>
612-
<dt class="field-odd">Required</dt>
613-
<dd class="field-odd"><p>true</p>
614-
</dd>
615612
<dt class="field-odd">Default</dt>
616613
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
617614
</dd>
@@ -636,9 +633,6 @@ <h2>Confvals<a class="headerlink" href="#confvals" data-bs-toggle="modal" data-b
636633
<dt class="field-even">Type</dt>
637634
<dd class="field-even">string
638635
</dd>
639-
<dt class="field-odd">Required</dt>
640-
<dd class="field-odd"><p>true</p>
641-
</dd>
642636
<dt class="field-odd">Default</dt>
643637
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
644638
</dd>
@@ -659,9 +653,6 @@ <h2>Confvals<a class="headerlink" href="#confvals" data-bs-toggle="modal" data-b
659653
<dt class="field-even">Type</dt>
660654
<dd class="field-even">string
661655
</dd>
662-
<dt class="field-odd">Required</dt>
663-
<dd class="field-odd"><p>true</p>
664-
</dd>
665656
<dt class="field-odd">Default</dt>
666657
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
667658
</dd>
@@ -682,9 +673,6 @@ <h2>Confvals<a class="headerlink" href="#confvals" data-bs-toggle="modal" data-b
682673
<dt class="field-even">Type</dt>
683674
<dd class="field-even">string
684675
</dd>
685-
<dt class="field-odd">Required</dt>
686-
<dd class="field-odd"><p>true</p>
687-
</dd>
688676
<dt class="field-odd">Default</dt>
689677
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
690678
</dd>
@@ -708,9 +696,6 @@ <h2>Confvals<a class="headerlink" href="#confvals" data-bs-toggle="modal" data-b
708696
<dt class="field-even">Type</dt>
709697
<dd class="field-even">string
710698
</dd>
711-
<dt class="field-odd">Required</dt>
712-
<dd class="field-odd"><p>true</p>
713-
</dd>
714699
<dt class="field-odd">Default</dt>
715700
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
716701
</dd>
@@ -737,9 +722,6 @@ <h2>Confvals<a class="headerlink" href="#confvals" data-bs-toggle="modal" data-b
737722
<dt class="field-even">Type</dt>
738723
<dd class="field-even">string
739724
</dd>
740-
<dt class="field-odd">Required</dt>
741-
<dd class="field-odd"><p>true</p>
742-
</dd>
743725
<dt class="field-odd">Default</dt>
744726
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
745727
</dd>
@@ -767,9 +749,6 @@ <h2>Confvals<a class="headerlink" href="#confvals" data-bs-toggle="modal" data-b
767749
<dt class="field-even">Type</dt>
768750
<dd class="field-even">string
769751
</dd>
770-
<dt class="field-odd">Required</dt>
771-
<dd class="field-odd"><p>true</p>
772-
</dd>
773752
<dt class="field-odd">Default</dt>
774753
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
775754
</dd>
@@ -794,9 +773,6 @@ <h2>Confvals<a class="headerlink" href="#confvals" data-bs-toggle="modal" data-b
794773
<dt class="field-even">Type</dt>
795774
<dd class="field-even">string
796775
</dd>
797-
<dt class="field-odd">Required</dt>
798-
<dd class="field-odd"><p>true</p>
799-
</dd>
800776
<dt class="field-odd">Default</dt>
801777
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
802778
</dd>
@@ -821,9 +797,6 @@ <h2>Confvals<a class="headerlink" href="#confvals" data-bs-toggle="modal" data-b
821797
<dt class="field-even">Type</dt>
822798
<dd class="field-even">string
823799
</dd>
824-
<dt class="field-odd">Required</dt>
825-
<dd class="field-odd"><p>true</p>
826-
</dd>
827800
<dt class="field-odd">Default</dt>
828801
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
829802
</dd>

tests/Integration/tests/confval/confval-noindex/expected/anotherDomain.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ <h1>Confval in another domain<a class="headerlink" href="#confval-in-another-dom
1111
<dt class="field-even">Type</dt>
1212
<dd class="field-even">string
1313
</dd>
14-
<dt class="field-odd">Required</dt>
15-
<dd class="field-odd"><p>true</p>
16-
</dd>
1714
<dt class="field-odd">Default</dt>
1815
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
1916
</dd>

tests/Integration/tests/confval/confval-noindex/expected/index.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ <h1>Confval<a class="headerlink" href="#confval" data-bs-toggle="modal" data-bs-
1111
<dt class="field-even">Type</dt>
1212
<dd class="field-even">string
1313
</dd>
14-
<dt class="field-odd">Required</dt>
15-
<dd class="field-odd"><p>true</p>
16-
</dd>
1714
<dt class="field-odd">Default</dt>
1815
<dd class="field-odd"><code class="code-inline" translate="no">&quot;Hello World&quot;</code>
1916
</dd>

0 commit comments

Comments
 (0)