From 4f63852c11836399659af6593bf74a247a2c4a49 Mon Sep 17 00:00:00 2001 From: Kyle Hopfer Date: Wed, 20 Aug 2025 08:39:46 -0500 Subject: [PATCH 1/2] Fixing issue where table.getIsSomeRowsSelected returns incorrect value when filtered out rows are selected --- packages/table-core/src/features/RowSelection.ts | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/packages/table-core/src/features/RowSelection.ts b/packages/table-core/src/features/RowSelection.ts index 90166823aa..8e3bca810d 100644 --- a/packages/table-core/src/features/RowSelection.ts +++ b/packages/table-core/src/features/RowSelection.ts @@ -1,11 +1,11 @@ import { OnChangeFn, - Table, Row, - RowModel, - Updater, RowData, + RowModel, + Table, TableFeature, + Updater, } from '../types' import { getMemoOptions, makeStateUpdater, memo } from '../utils' @@ -431,12 +431,11 @@ export const RowSelection: TableFeature = { } table.getIsSomeRowsSelected = () => { - const totalSelected = Object.keys( - table.getState().rowSelection ?? {} - ).length + const visibleRows = table.getFilteredRowModel().flatRows + const selectedVisibleRows = visibleRows.filter(row => row.getIsSelected()) return ( - totalSelected > 0 && - totalSelected < table.getFilteredRowModel().flatRows.length + selectedVisibleRows.length > 0 && + selectedVisibleRows.length < visibleRows.length ) } From 756483a8baefab84ac482283ce53f83a9d69b3a2 Mon Sep 17 00:00:00 2001 From: Kyle Hopfer Date: Wed, 20 Aug 2025 08:44:55 -0500 Subject: [PATCH 2/2] Reverting import order change --- packages/table-core/src/features/RowSelection.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/table-core/src/features/RowSelection.ts b/packages/table-core/src/features/RowSelection.ts index 8e3bca810d..f7252a20de 100644 --- a/packages/table-core/src/features/RowSelection.ts +++ b/packages/table-core/src/features/RowSelection.ts @@ -1,11 +1,11 @@ import { OnChangeFn, + Table, Row, - RowData, RowModel, - Table, - TableFeature, Updater, + RowData, + TableFeature, } from '../types' import { getMemoOptions, makeStateUpdater, memo } from '../utils'