New attempt at suppressing bad lint

Author: ThomasHabets

cmd/cmdg/view_messagelist.go

@@ -712,7 +712,9 @@ func (mv *MessageView) Run(ctx context.Context) error {
 			log.Debugf("MessageListView got key %q", key)
 			switch key {
 			case "?", input.F1:
-				help(messageListViewHelp, mv.keys)
+                                if err := help(messageListViewHelp, mv.keys); err != nil {
+                                        log.Infof("help() failed: %v", err)
+                                }
 			case input.Enter, input.Right:
 				if len(mv.messages) == 0 {
 					// Let's assume we've never gotten to the state where mv.pos >= len(mv.messages)

cmd/cmdg/view_openmessage.go

@@ -334,7 +334,9 @@ func (ov *OpenMessageView) incrementalSearch(ctx context.Context, inlines []stri
 	defer func() { ov.inIncrementalSearch = false }()
 	ov.incrementalQuery = ""
 
-	ov.Draw(lines, 0)
+        if err := ov.Draw(lines, 0); err != nil {
+                log.Infof("Failed to draw: %v", err)
+        }
 	ov.screen.Draw()
 
 	found := 0
@@ -497,7 +499,9 @@ func (ov *OpenMessageView) Run(ctx context.Context) (*MessageViewOp, error) {
 			ov.screen.Clear()
 
 			// TODO: double check that scroll is not too high after `lines` was recreated.
-			ov.Draw(lines, scroll)
+                        if err := ov.Draw(lines, scroll); err != nil {
+                                log.Infof("Failed to draw: %v", err)
+                        }
 		case key, ok := <-ov.keys.Chan():
 			if !ok {
 				log.Errorf("OpenMessage: Input channel closed!")
@@ -513,7 +517,9 @@ func (ov *OpenMessageView) Run(ctx context.Context) (*MessageViewOp, error) {
 					ov.update <- struct{}{}
 				}()
 			case "?", input.F1:
-				help(openMessageViewHelp, ov.keys)
+                                if err := help(openMessageViewHelp, ov.keys); err != nil {
+                                        log.Infof("help() failed: %v", err)
+                                }
 			case "*":
 				if ov.msg.HasLabel(cmdg.Starred) {
 					if err := ov.msg.RemoveLabelID(ctx, cmdg.Starred); err != nil {
@@ -593,7 +599,7 @@ func (ov *OpenMessageView) Run(ctx context.Context) (*MessageViewOp, error) {
 				return OpNext(), nil
 			case "U":
 				if err := ov.msg.AddLabelID(ctx, cmdg.Unread); err != nil {
-                                        //nolint:staticcheck
+                                        //lint:ignore ST1005 UI-facing message intentionally starts with capital
 					ov.errors <- fmt.Errorf("Failed to mark unread : %v", err)
 				} else {
 					return nil, nil
@@ -614,17 +620,17 @@ func (ov *OpenMessageView) Run(ctx context.Context) (*MessageViewOp, error) {
 				ov.Draw(lines, scroll)
 			case "f":
 				if err := forward(ctx, conn, ov.keys, ov.msg); err != nil {
-                                        //nolint:staticcheck
+                                        //lint:ignore ST1005 UI-facing message intentionally starts with capital
 					ov.errors <- fmt.Errorf("Failed to forward: %v", err)
 				}
 			case "r":
 				if err := reply(ctx, conn, ov.keys, ov.msg); err != nil {
-                                        //nolint:staticcheck
+                                        //lint:ignore ST1005 UI-facing message intentionally starts with capital
 					ov.errors <- fmt.Errorf("Failed to reply: %v", err)
 				}
 			case "a":
 				if err := replyAll(ctx, conn, ov.keys, ov.msg); err != nil {
-                                        //nolint:staticcheck
+                                        //lint:ignore ST1005 UI-facing message intentionally starts with capital
 					ov.errors <- fmt.Errorf("Failed to replyAll: %v", err)
 				}
 			case "H":
@@ -717,7 +723,11 @@ func (ov *OpenMessageView) showRaw(ctx context.Context) error {
 
 func (ov *OpenMessageView) showPager(ctx context.Context, content string) error {
 	ov.keys.Stop()
-	defer ov.keys.Start()
+	defer func() {
+                if err := ov.keys.Start(); err != nil {
+                        log.Infof("Failed to restart input: %v", err)
+                }
+        }()
 
 	cmd := exec.CommandContext(ctx, pagerBinary)
 	cmd.Stdin = strings.NewReader(content)