Skip to content

Commit 3a72bba

Browse files
authored
Merge pull request #2 from jmcvetta/master
Python 3 compatibility
2 parents e7ddcfe + 76201ce commit 3a72bba

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

multi_form_view/base.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
from django.http import HttpResponseRedirect
55
from django.shortcuts import render
66
from django.views.generic import FormView
7+
import six
78

89

910
class MultiFormView(FormView):
@@ -16,7 +17,7 @@ def are_forms_valid(self, forms):
1617
"""
1718
Check if all forms defined in `form_classes` are valid.
1819
"""
19-
for form in forms.itervalues():
20+
for form in six.itervalues(forms):
2021
if not form.is_valid():
2122
return False
2223
return True
@@ -60,7 +61,7 @@ def get_forms(self):
6061
forms = {}
6162
initial = self.get_initial()
6263
form_kwargs = self.get_form_kwargs()
63-
for key, form_class in self.form_classes.iteritems():
64+
for key, form_class in six.iteritems(self.form_classes):
6465
forms[key] = form_class(initial=initial[key], **form_kwargs)
6566
return forms
6667

@@ -81,7 +82,7 @@ def get_initial(self):
8182
Returns a copy of `initial` with empty initial data dictionaries for each form.
8283
"""
8384
initial = super(MultiFormView, self).get_initial()
84-
for key in self.form_classes.iterkeys():
85+
for key in six.iterkeys(self.form_classes):
8586
initial[key] = {}
8687
return initial
8788

@@ -105,7 +106,7 @@ def forms_valid(self, forms):
105106
"""
106107
Calls `save()` on each form.
107108
"""
108-
for form in forms.itervalues():
109+
for form in six.itervalues(forms):
109110
form.save()
110111
return super(MultiModelFormView, self).forms_valid(forms)
111112

@@ -118,7 +119,7 @@ def get_forms(self):
118119
objects = self.get_objects()
119120
initial = self.get_initial()
120121
form_kwargs = self.get_form_kwargs()
121-
for key, form_class in self.form_classes.iteritems():
122+
for key, form_class in six.iteritems(self.form_classes):
122123
forms[key] = form_class(instance=objects[key], initial=initial[key], **form_kwargs)
123124
return forms
124125

@@ -128,6 +129,6 @@ def get_objects(self):
128129
corresponding form.
129130
"""
130131
objects = {}
131-
for key in self.form_classes.iterkeys():
132+
for key in six.iterkeys(self.form_classes):
132133
objects[key] = None
133134
return objects

0 commit comments

Comments
 (0)