FFupdate keeps crashing after finishing firefox download

[RalfJung]

Describe the bug
FFupdate keeps crashing after finishing firefox download

To Reproduce
I have FF 133 installed and I am trying to update to 134.

Expected behavior
It should download the update and then install it.

Error message from FFUpdater
Stacktrace:

java.lang.IllegalArgumentException: Downloaded or extracted APK file is not a valid ZIP file.
	at de.marmaro.krt.ffupdater.app.impl.base.ApkDownloader$DefaultImpls.checkApkFile(ApkDownloader.kt:148)
	at de.marmaro.krt.ffupdater.app.impl.base.ApkDownloader$DefaultImpls.access$checkApkFile(ApkDownloader.kt:21)
	at de.marmaro.krt.ffupdater.app.impl.base.ApkDownloader$checkApkFile$1.invokeSuspend(ApkDownloader.kt:0)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at android.os.Handler.handleCallback(Handler.java:938)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7870)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@61705fb, Dispatchers.Main.immediate]

Logs:

java.lang.IllegalArgumentException: Downloaded or extracted APK file is not a valid ZIP file.
	at de.marmaro.krt.ffupdater.app.impl.base.ApkDownloader$DefaultImpls.checkApkFile(ApkDownloader.kt:148)
	at de.marmaro.krt.ffupdater.app.impl.base.ApkDownloader$DefaultImpls.access$checkApkFile(ApkDownloader.kt:21)
	at de.marmaro.krt.ffupdater.app.impl.base.ApkDownloader$checkApkFile$1.invokeSuspend(ApkDownloader.kt:0)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at android.os.Handler.handleCallback(Handler.java:938)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7870)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@61705fb, Dispatchers.Main.immediate]

Device information:

Key	Value
FFUpdater version	79.3.1 (177) release Github
Device	moto g(7) power (lineage_ocean, ocean, SDM632)
Manufacturer	motorola (motorola)
Supported ABIs	arm64-v8a, armeabi-v7a, armeabi
Android version	12 (SDK: 32)
OS	33a071032b8f, root, dev-keys, 1671587880000

[RalfJung]

This is odd, after just waiting for a bit I got a notification saying the update was installed in the background.

Maybe FFUpdater got confused because I manually clicked the "update" button while it was doing the same thing in the background?

[Tobi823]

FFupdate keeps crashing after finishing firefox download

Do you mean an error message or a crash of the entire app?

[Tobi823]

Maybe FFUpdater got confused because I manually clicked the "update" button while it was doing the same thing in the background?

My suspicion is, that for some reason the downloaded APK file got corrupted. But the background update checker deleted the corrupted APK and tried again

[RalfJung]

Do you mean an error message or a crash of the entire app?

I got the crash reporting window telling me to report on github, gitlab, or something else. So I think this is a crash of the entire app.

[Tobi823]

It seems that I have to improve my code and catch + handle this errors.

[Tobi823]

I improved it further :)