remove anys, add proper types

Author: themisvaltinos

vscode/extension/src/commands/tableDiff.ts

@@ -4,6 +4,12 @@ import { isErr } from '@bus/result'
 import { CallbackEvent, RPCRequest } from '@bus/callbacks'
 import { getWorkspaceFolders } from '../utilities/common/vscodeapi'
 
+interface ModelInfo {
+  name: string
+  fqn: string
+  description?: string | null
+}
+
 export function showTableDiff(
   lspClient?: LSPClient,
   extensionUri?: vscode.Uri,
@@ -21,7 +27,7 @@ export function showTableDiff(
 
     // Get the current active editor
     const activeEditor = vscode.window.activeTextEditor
-    let selectedModelInfo: any = null
+    let selectedModelInfo: ModelInfo | null = null
 
     if (!activeEditor) {
       // No active editor, show a list of all models
@@ -46,8 +52,8 @@ export function showTableDiff(
       }
 
       // Let user choose from all models
-      const items = (allModelsResult.value.models as any[]).map(
-        (model: any) => ({
+      const items = (allModelsResult.value.models as ModelInfo[]).map(
+        (model: ModelInfo) => ({
           label: model.name,
           description: model.fqn,
           detail: model.description ? model.description : undefined,
@@ -118,6 +124,12 @@ export function showTableDiff(
       }
     }
 
+    // Ensure we have a selected model
+    if (!selectedModelInfo) {
+      vscode.window.showErrorMessage('No model selected')
+      return
+    }
+
     // Get environments for selection
     const environmentsResult = await lspClient.call_custom_method(
       'sqlmesh/get_environments',

vscode/react/src/components/tablediff/TableDiff.tsx

@@ -3,6 +3,15 @@ import LoadingStatus from '../loading/LoadingStatus'
 import { TableDiffResults } from './TableDiffResults'
 import { callRpc } from '../../utils/rpc'
 
+// Type for data values in samples - can be strings, numbers, booleans, or null
+type SampleValue = string | number | boolean | null
+
+// Type for row data in samples
+type SampleRow = Record<string, SampleValue>
+
+// Type for column statistics
+type ColumnStats = Record<string, number | string | null>
+
 interface TableDiffData {
   schema_diff: {
     source: string
@@ -17,19 +26,19 @@ interface TableDiffData {
     source: string
     target: string
     stats: Record<string, number>
-    sample: Record<string, any>
-    joined_sample: Record<string, any>
-    s_sample: Record<string, any>
-    t_sample: Record<string, any>
-    column_stats: Record<string, any>
+    sample: Record<string, SampleValue[]>
+    joined_sample: Record<string, SampleValue[]>
+    s_sample: Record<string, SampleValue[]>
+    t_sample: Record<string, SampleValue[]>
+    column_stats: ColumnStats
     source_count: number
     target_count: number
     count_pct_change: number
     decimals: number
     processed_sample_data?: {
-      column_differences: Array<Record<string, any>>
-      source_only: Array<Record<string, any>>
-      target_only: Array<Record<string, any>>
+      column_differences: SampleRow[]
+      source_only: SampleRow[]
+      target_only: SampleRow[]
     }
   }
   on: string[][]