Skip to content

Improvements to win animation #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tomin1 opened this issue May 1, 2023 · 1 comment
Open

Improvements to win animation #14

Tomin1 opened this issue May 1, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Tomin1
Copy link
Owner

Tomin1 commented May 1, 2023

A basic version of win animation was implemented in #5 but that could be further improved. In particular I'd like to see more variation in the animations, perhaps different (selectable) animations, if there are enough viable ideas to implement. Feel free to tell about your ideas and experiment with the code. Note that there are some things you need to consider:

  • Some games have stacks of cards per suit, like Klondike.
  • Some games put those stacks to other positions on the table, like Beleaguered castle.
  • Some games have single cards on the table, like Maze.
  • Some games expanding stacks of cards, like Osmosis.
  • Some games don't have any cards on the table at the end, like Helsinki.
  • Some games have a combination of these, like Wall.

Yeah, it's a lot to consider. But any improvements, big or small are welcome to be discussed.

@Tomin1 Tomin1 added the enhancement New feature or request label May 1, 2023
@Tomin1 Tomin1 mentioned this issue May 1, 2023
@Tomin1
Copy link
Owner Author

Tomin1 commented Dec 25, 2024

I wonder if the cards should rotate while they are thrown around. This would be something to experiment with. I think the current animation could be improved if the cards were rotating at least a little bit. Also some kind of curve that would make the cards slow down to halt would be good too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant