Fix Scratch import/export reliability in IDE#99
Merged
TopProjectsCreator merged 1 commit intoApr 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fileNamesis stale or incomplete.Description
exportSb3insrc/services/scratchSb3.tsto export the union ofarchive.fileNamesandObject.keys(archive.files)so assets present infilesare always included.handleImportinsrc/components/scratch/ScratchPanel.tsxby resetting the hidden file input value after each import attempt (importInputRef.current.value = '') so the same file can be re-imported.handleExportinsrc/components/scratch/ScratchPanel.tsxwithtry/catch, use a safer browser download flow (document.body.appendChild(a)→a.click()→a.remove()→ delayedURL.revokeObjectURL), and surface failures viasetVmError.src/test/scratchSb3.test.tsthat verifies assets infilesare exported even whenfileNamesonly containsproject.json.Testing
npm test -- --run src/test/scratchSb3.test.ts, which completed successfully with2 tests passed.Codex Task