Merge pull request #226 from TransactionProcessing/codacy/high_fixes

workflow changes

Author: StuartFerguson

.github/workflows/codacy.yml

@@ -1,4 +1,4 @@
-name: Codacy Bootstrap Issues
+name: Sync Codacy Issues
 
 on:
   workflow_dispatch:
@@ -10,7 +10,7 @@ on:
   push:
     # branches to consider in the event; optional, defaults to all
     branches:
-      - main
+      - master
 jobs:
   sync-codacy-issues:
     runs-on: ubuntu-latest
@@ -99,3 +99,71 @@ jobs:
                 await new Promise(resolve => setTimeout(resolve, 2000));
               }
             }
+
+      - name: Close Resolved GitHub Issues
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const fs = require('fs');
+            const dryRun = "${{ github.event.inputs.dry_run }}" === "true";
+            const rawIssues = JSON.parse(fs.readFileSync('filtered_issues.json', 'utf8'));
+
+            // Build current Codacy set (only *active* issues, not ignored)
+            const currentCodacyIds = new Set(
+              rawIssues.filter(i => !i.ignored).map(i => i.issueId)
+            );
+
+            // Build ignored Codacy set
+            const ignoredCodacyIds = new Set(
+              rawIssues.filter(i => i.ignored).map(i => i.issueId)
+            );
+
+            // Fetch ALL GitHub issues with codacy label
+            const allIssues = await github.paginate(
+              github.rest.issues.listForRepo,
+              {
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                state: "all",
+                labels: ["codacy"]
+              }
+            );
+
+            for (const ghIssue of allIssues) {
+              const matches = ghIssue.body?.match(/codacy-issue-([a-f0-9]+)/g);
+              if (!matches) continue;
+
+              for (const match of matches) {
+                const issueId = match.replace("codacy-issue-", "");
+
+                // Close if not active OR explicitly ignored
+                if ((!currentCodacyIds.has(issueId) || ignoredCodacyIds.has(issueId)) 
+                    && ghIssue.state === "open") {
+                  if (dryRun) {
+                    console.log(`[DRY RUN] Would close issue #${ghIssue.number} (Codacy issueId ${issueId})`);
+                  } else {
+                    // Add comment before closing
+                    const reason = ignoredCodacyIds.has(issueId)
+                      ? "Auto closed because Codacy issue is marked as *ignored*"
+                      : "Auto closed as not found in last analysis";
+
+                    await github.rest.issues.createComment({
+                      owner: context.repo.owner,
+                      repo: context.repo.repo,
+                      issue_number: ghIssue.number,
+                      body: reason
+                    });
+
+                    await github.rest.issues.update({
+                      owner: context.repo.owner,
+                      repo: context.repo.repo,
+                      issue_number: ghIssue.number,
+                      state: "closed"
+                    });
+                    console.log(`❌ Closed GitHub issue #${ghIssue.number} for Codacy issueId ${issueId}`);
+                  }
+                }
+              }
+            }
+
+            

.github/workflows/nightlybuild.yml

@@ -34,11 +34,19 @@ jobs:
         dotnet test "EstateManagementUI.BusinessLogic.Tests\EstateManagementUI.BusinessLogic.Tests.csproj" /p:CollectCoverage=true /p:Exclude="[xunit*]*" /p:ExcludeByAttribute="Obsolete" /p:ExcludeByAttribute="GeneratedCodeAttribute" /p:ExcludeByAttribute="CompilerGeneratedAttribute" /p:ExcludeByAttribute="ExcludeFromCodeCoverageAttribute" /p:CoverletOutput="../lcov1.info" /maxcpucount:1 /p:CoverletOutputFormat="lcov"
         dotnet test "EstateManagementUI.UITests\EstateManagementUI.UITests.csproj"   /p:CollectCoverage=true /p:Exclude="[xunit*]*" /p:ExcludeByAttribute="Obsolete" /p:ExcludeByAttribute="GeneratedCodeAttribute" /p:ExcludeByAttribute="CompilerGeneratedAttribute" /p:ExcludeByAttribute="ExcludeFromCodeCoverageAttribute" /p:CoverletOutput="../lcov2.info" /maxcpucount:1 /p:CoverletOutputFormat="lcov"
 
-    - name: Upload coverage reports to Codecov
-      uses: codecov/codecov-action@v3  
+    - name: Install LCOV merger
+      run: npm install -g lcov-result-merger
+
+    - name: Merge LCOV reports
+      run: |
+        mkdir -p coverage
+        lcov-result-merger "*.info" > lcov.info
+
+    - name: Upload merged coverage to Codacy
+      uses: codacy/codacy-coverage-reporter-action@v1
       with:
-        token: ${{ secrets.CODECOV_TOKEN }} 
-        files: ./lcov1.info,./lcov2.info
+        project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}
+        coverage-reports: ./lcov.info
 
   chrometests:
     name: "Nightly Build - Chrome"