Make date range dynamic in query; improve test assertions

Updated ReportingManager to use request-supplied start and end dates for grand total amount queries instead of hardcoded values. Enhanced TransactionsEndpointTests by asserting that PercentageOfTotal is non-zero, ensuring more robust test coverage.

Author: StuartFerguson

EstateReportingAPI.BusinessLogic/ReportingManager.cs

@@ -1157,7 +1157,7 @@ public async Task<Result<ProductPerformanceResponse>> GetProductPerformanceRepor
         using ResolvedDbContext<EstateManagementContext>? resolvedContext = this.Resolver.Resolve(EstateManagementDatabaseName, request.EstateId.ToString());
         await using EstateManagementContext context = resolvedContext.Context;
 
-        var grandTotalAmountQuery = (from t in context.Transactions where t.TransactionType == "Sale" && t.TransactionDate >= new DateTime(2025, 12, 21) && t.TransactionDate <= new DateTime(2025, 12, 25) select t.TransactionAmount);
+        var grandTotalAmountQuery = (from t in context.Transactions where t.TransactionType == "Sale" && t.TransactionDate >= request.StartDate && t.TransactionDate <= request.EndDate select t.TransactionAmount);
         var grandTotalAmountResult = await ExecuteQuerySafeSum<decimal>(grandTotalAmountQuery, cancellationToken);
         if (grandTotalAmountResult.IsFailed)
             return ResultHelpers.CreateFailure(grandTotalAmountResult);

EstateReportingAPI.IntegrationTests/TransactionsEndpointTests.cs

@@ -938,6 +938,7 @@ public async Task TransactionsEndpoint_ProductPerformanceReport_SummaryDataRetur
             productPerformanceResponseDetail.ShouldNotBeNull();
             productPerformanceResponseDetail.TransactionCount.ShouldBe(transactions.Count(t => t.ContractProductId == product.productId));
             productPerformanceResponseDetail.TransactionValue.ShouldBe(transactions.Where(t => t.ContractProductId == product.productId).Sum(t => t.TransactionAmount));
+            productPerformanceResponseDetail.PercentageOfTotal.ShouldNotBe(0);
         }
     }