Merge pull request #59 from TransactionProcessing/bug/#56_silenthandleduplicatefilecreate

Silently handle duplicate file creates

Author: StuartFerguson

FileProcessor.FileAggregate.Tests/FileAggregateTests.cs

@@ -53,18 +53,23 @@ public void FileAggregate_CreateFile_FileIsCreated()
         }
 
         [Fact]
-        public void FileAggregate_CreateFile_FileAlreadyCreated_ErrorThrown()
+        public void FileAggregate_CreateFile_FileAlreadyCreated_NoErrorThrown()
         {
             FileAggregate fileAggregate = FileAggregate.Create(TestData.FileId);
             fileAggregate.CreateFile(TestData.FileImportLogId, TestData.EstateId, TestData.MerchantId, TestData.UserId,
                                      TestData.FileProfileId, TestData.FileLocation, TestData.FileUploadedDateTime);
 
-            Should.Throw<InvalidOperationException>(() =>
-                                                    {
-
-                                                        fileAggregate.CreateFile(TestData.FileImportLogId, TestData.EstateId, TestData.MerchantId, TestData.UserId,
-                                                                                 TestData.FileProfileId, TestData.FileLocation, TestData.FileUploadedDateTime);
-                                                    });
+            Should.NotThrow(() =>
+                            {
+
+                                fileAggregate.CreateFile(TestData.FileImportLogId,
+                                                         TestData.EstateId,
+                                                         TestData.MerchantId,
+                                                         TestData.UserId,
+                                                         TestData.FileProfileId,
+                                                         TestData.FileLocation,
+                                                         TestData.FileUploadedDateTime);
+                            });
         }
 
         [Fact]

FileProcessor.FileAggregate/FileAggregate.cs

@@ -247,9 +247,7 @@ private void PlayEvent(FileProcessingCompletedEvent domainEvent)
         public void CreateFile(Guid fileImportLogId, Guid estateId, Guid merchantId, Guid userId, Guid fileProfileId, String fileLocation, DateTime fileReceivedDateTime)
         {
             if (this.IsCreated)
-            {
-                throw new InvalidOperationException($"File Id {this.AggregateId} has already been created");
-            }
+                return;
 
             FileCreatedEvent fileCreatedEvent = new FileCreatedEvent(this.AggregateId, fileImportLogId, estateId, merchantId, userId, fileProfileId, fileLocation, fileReceivedDateTime);