Merge pull request #73 from TransactionProcessing/codacy/high_fixes

StuartFerguson · web-flow · commit fd0b6eb0e573 · 2025-10-03T17:35:05.000+01:00
some fixes
diff --git a/MobileConfiguration/Database/Extensions.cs b/MobileConfiguration/Database/Extensions.cs
@@ -19,9 +19,6 @@ public static ModelBuilder SetupConfigurationTable(this ModelBuilder modelBuilde
                                                                  r.Id,
                                                                  r.ConfigType
                                                              });
-
-        // TODO: FK on LogLevel
-
         return modelBuilder;
     }
 
diff --git a/MobileConfiguration/Repository/IConfigurationRepository.cs b/MobileConfiguration/Repository/IConfigurationRepository.cs
@@ -40,7 +40,6 @@ public async Task<MobileConfiguration> GetConfiguration(ConfigurationType config
                 throw new NotFoundException($"No config of type [{configurationType}] found for Id [{id}]");
             }
 
-            // TODO: create a factory
             MobileConfiguration configurationModel = new() {
                                                                                  ClientId = configuration.ClientId,
                                                                                  ClientSecret = configuration.ClientSecret,

Original file line number	Diff line number	Diff line change
`@@ -19,9 +19,6 @@ public static ModelBuilder SetupConfigurationTable(this ModelBuilder modelBuilde`
`19`	`19`	`r.Id,`
`20`	`20`	`r.ConfigType`
`21`	`21`	`});`
`22`		`-`
`23`		`- // TODO: FK on LogLevel`
`24`		`-`
`25`	`22`	`return modelBuilder;`
`26`	`23`	`}`
`27`	`24`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,6 @@ public async Task<MobileConfiguration> GetConfiguration(ConfigurationType config`
`40`	`40`	`throw new NotFoundException($"No config of type [{configurationType}] found for Id [{id}]");`
`41`	`41`	`}`
`42`	`42`
`43`		`- // TODO: create a factory`
`44`	`43`	`MobileConfiguration configurationModel = new() {`
`45`	`44`	`ClientId = configuration.ClientId,`
`46`	`45`	`ClientSecret = configuration.ClientSecret,`