Merge pull request #139 from TransactionProcessing/task/#130_addcodefactor

Code format to trigger PR

Author: StuartFerguson

README.md

@@ -3,6 +3,9 @@
 ## Build Status
 [![Last Release Status Badge](https://github.com/StuartFerguson/Shared/workflows/Release/badge.svg)](https://github.com/StuartFerguson/Shared/workflows/Release/badge.svg)
 
+## CodeFactor Code Quality
+[![CodeFactor](https://www.codefactor.io/repository/github/transactionprocessing/shared/badge)](https://www.codefactor.io/repository/github/transactionprocessing/shared)
+
 ## Nuget Versions
 |||
 | --- | --- |

Shared.EventStore/Aggregate/Aggregate.cs

@@ -14,8 +14,7 @@ public abstract class Aggregate
         /// <summary>
         /// Initializes a new instance of the <see cref="Aggregate" /> class.
         /// </summary>
-        protected Aggregate()
-        {
+        protected Aggregate() {
             this.EventHistory = new Dictionary<Guid, IDomainEvent>();
             this.PendingEvents = new List<IDomainEvent>();
             this.Version = -1L;
@@ -41,6 +40,14 @@ protected Aggregate()
         /// </value>
         public AggregateVersion Version { get; internal set; }
 
+        /// <summary>
+        /// Gets the number of historical events.
+        /// </summary>
+        /// <value>
+        /// The number of historical events.
+        /// </value>
+        protected Int64 NumberOfHistoricalEvents => this.EventHistory.Count;
+
         /// <summary>
         /// Gets or sets the event history.
         /// </summary>
@@ -65,46 +72,34 @@ protected Aggregate()
         /// Applies the and append.
         /// </summary>
         /// <param name="domainEvent">The domain event.</param>
-        public void ApplyAndAppend(IDomainEvent domainEvent)
-        {
+        public void ApplyAndAppend(IDomainEvent domainEvent) {
             if (domainEvent == null) return; //Silently handled
 
-            try
-            {
+            try {
                 if (this.IsEventDuplicate(domainEvent.EventId))
                     return;
 
                 this.PlayEvent(domainEvent);
                 this.PendingEvents.Add(domainEvent);
             }
-            catch (Exception e)
-            {
+            catch(Exception e) {
                 Exception ex = new Exception($"Failed to apply event {domainEvent.EventType} to Aggregate {this.GetType().Name}", e);
 
                 throw ex;
             }
         }
 
-        public Object GetAggregateMetadata()
-        {
+        public Object GetAggregateMetadata() {
             return this.GetMetadata();
         }
 
-        protected abstract Object GetMetadata();
-
         /// <summary>
         /// Plays the event.
         /// </summary>
         /// <param name="domainEvent">The domain event.</param>
         public abstract void PlayEvent(IDomainEvent domainEvent);
 
-        /// <summary>
-        /// Gets the number of historical events.
-        /// </summary>
-        /// <value>
-        /// The number of historical events.
-        /// </value>
-        protected Int64 NumberOfHistoricalEvents => EventHistory.Count;
+        protected abstract Object GetMetadata();
 
         #endregion
     }