Fix quick Codacy issues: performance improvement and best practice violations

Agent-Logs-Url: https://github.com/TransactionProcessing/SupportTools/sessions/7373b758-d29d-43de-a82d-3bc060d3ecb2

Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>

Author: Copilot

TransactionProcessing.MerchantFileProcessor/Clients/FileProcessingClient.cs

@@ -43,7 +43,6 @@ public async Task<Result<Guid>> Upload(MerchantOptions merchant,
         };
 
         Result<Guid>? result = await fileProcessorClient.UploadFile(accessToken, file.FileName, file.Content, request, cancellationToken);
-        //var result = Result.Success(Guid.NewGuid()); // TODO: Replace with actual file upload call
 
         if (result.IsFailed) {
             return new Result<Guid> { IsSuccess = false, Status = ResultStatus.Failure, Message = $"File processor client failed to upload file '{file.FileName}'." };
@@ -71,7 +70,7 @@ public async Task<Result<FileProcessingStatusSnapshot>> GetFileStatus(string acc
     private static FileProcessingLineStatusSnapshot MapLineStatus(FileLine line) => new(line.LineNumber, line.LineData, line.ProcessingResult.ToString(), string.IsNullOrWhiteSpace(line.RejectionReason) ? null : line.RejectionReason, line.TransactionId == Guid.Empty ? null : line.TransactionId);
 
     private static bool AreAllLinesResolved(IEnumerable<FileProcessingLineStatusSnapshot> lines) {
-        Boolean hasLines = false;
+        bool hasLines = false;
 
         foreach (FileProcessingLineStatusSnapshot line in lines) {
             hasLines = true;

TransactionProcessing.MerchantFileProcessor/FileBuilding/DelimitedTransactionFileBuilder.cs

@@ -11,9 +11,9 @@ public GeneratedFile Build(MerchantOptions merchant,
                                FileProfileOptions fileProfile,
                                IReadOnlyList<GeneratedTransaction> transactions,
                                DateTimeOffset processingTimestampUtc) {
-        String delimiter = NormalizeDelimiter(fileProfile.Delimited.Delimiter);
-        List<String> lines = new List<string>();
-        Decimal fileTotalAmount = transactions.Sum(transaction => transaction.TotalAmount);
+        string delimiter = NormalizeDelimiter(fileProfile.Delimited.Delimiter);
+        List<string> lines = new List<string>();
+        decimal fileTotalAmount = transactions.Sum(transaction => transaction.TotalAmount);
 
         if (fileProfile.Delimited.HeaderFields.Count > 0) {
             TransactionFileContext headerContext = new TransactionFileContext(merchant, contract, null, processingTimestampUtc, transactions.Count, fileTotalAmount);
@@ -43,8 +43,8 @@ public GeneratedFile Build(MerchantOptions merchant,
 
     private static string Escape(string value,
                                  string delimiter) {
-        Boolean shouldQuote = value.Contains('"') || value.Contains('\r') || value.Contains('\n') || value.Contains(delimiter, StringComparison.Ordinal);
-        String escapedValue = value.Replace("\"", "\"\"", StringComparison.Ordinal);
+        bool shouldQuote = value.Contains('"') || value.Contains('\r') || value.Contains('\n') || value.Contains(delimiter, StringComparison.Ordinal);
+        string escapedValue = value.Replace("\"", "\"\"", StringComparison.Ordinal);
 
         return shouldQuote ? $"\"{escapedValue}\"" : escapedValue;
     }

TransactionProcessing.MerchantFileProcessor/FileBuilding/JsonTransactionFileBuilder.cs

@@ -14,6 +14,7 @@ public GeneratedFile Build(
         IReadOnlyList<GeneratedTransaction> transactions,
         DateTimeOffset processingTimestampUtc)
     {
+        var fileTotalAmount = transactions.Sum(transaction => transaction.TotalAmount);
         var mappedRecords = transactions
             .Select(transaction =>
             {
@@ -23,7 +24,7 @@ public GeneratedFile Build(
                     transaction,
                     processingTimestampUtc,
                     transactions.Count,
-                    transactions.Sum(candidate => candidate.TotalAmount));
+                    fileTotalAmount);
 
                 return fileProfile.Fields.ToDictionary(
                     field => field.Name,

TransactionProcessing.MerchantFileProcessor/Reporting/FileStatusReportService.cs

@@ -141,7 +141,7 @@ public async Task<string> RenderHtmlAsync(CancellationToken cancellationToken)
         var html = new StringBuilder();
 
         AppendDocumentStart(html, "Merchant File Status");
-        html.AppendLine($"  <h1>Merchant File Status</h1>");
+        html.AppendLine("  <h1>Merchant File Status</h1>");
         html.AppendLine($"  <p>Generated at {Encode(report.GeneratedUtc.ToString("u"))}. Auto-refreshes every 30 seconds.</p>");
         html.AppendLine("  <h2>Merchants</h2>");
         html.AppendLine("  <table>");
@@ -171,7 +171,7 @@ public async Task<string> RenderHtmlAsync(CancellationToken cancellationToken)
 
         var html = new StringBuilder();
         AppendDocumentStart(html, $"Merchant {report.Merchant.MerchantName} Details");
-        html.AppendLine($"  <p><a href=\"/status\">&larr; Back to merchants</a></p>");
+        html.AppendLine("  <p><a href=\"/status\">&larr; Back to merchants</a></p>");
         html.AppendLine($"  <h1>{Encode(report.Merchant.MerchantName)}</h1>");
         html.AppendLine($"  <p class=\"mono\">{Encode(report.Merchant.MerchantId)}</p>");
         html.AppendLine($"  <p>Generated at {Encode(report.GeneratedUtc.ToString("u"))}. Auto-refreshes every 30 seconds.</p>");
@@ -218,7 +218,7 @@ public async Task<string> RenderHtmlAsync(CancellationToken cancellationToken)
         var html = new StringBuilder();
         AppendDocumentStart(html, $"Merchant {report.Merchant.MerchantName} File {report.File.Id}");
         html.AppendLine($"  <p><a href=\"/status/{Uri.EscapeDataString(report.Merchant.MerchantId)}\">&larr; Back to merchant</a></p>");
-        html.AppendLine($"  <h1>File Details</h1>");
+        html.AppendLine("  <h1>File Details</h1>");
         html.AppendLine($"  <p>Merchant {Encode(report.Merchant.MerchantName)}<br /><span class=\"mono\">{Encode(report.Merchant.MerchantId)}</span></p>");
         html.AppendLine("  <table>");
         html.AppendLine("    <thead><tr><th>Processed (UTC)</th><th>Contract</th><th>Upload Status</th><th>Processing</th><th>Profile</th><th>Format</th></tr></thead>");

TransactionProcessing.MerchantFileProcessor/Worker.cs

@@ -76,14 +76,14 @@ private async Task<ScheduledMerchant> GetNextRunUtcAsync(DateTimeOffset now,
         IReadOnlyList<TimeOnly> runTimes = merchant.GetDailyRunTimesUtc();
         DateOnly currentDate = DateOnly.FromDateTime(now.UtcDateTime);
 
-        for (Int32 dayOffset = 0; dayOffset <= 1; dayOffset++) {
+        for (int dayOffset = 0; dayOffset <= 1; dayOffset++) {
             DateOnly candidateDate = currentDate.AddDays(dayOffset);
 
             foreach (TimeOnly runTime in runTimes) {
                 DateTimeOffset scheduledRunUtc = new DateTimeOffset(candidateDate.Year, candidateDate.Month, candidateDate.Day, runTime.Hour, runTime.Minute, runTime.Second, TimeSpan.Zero);
 
                 if (scheduledRunUtc <= now) {
-                    Boolean isComplete = await fileStatusStore.IsMerchantRunCompleteAsync(merchant, scheduledRunUtc, cancellationToken);
+                    bool isComplete = await fileStatusStore.IsMerchantRunCompleteAsync(merchant, scheduledRunUtc, cancellationToken);
                     if (!isComplete) {
                         LocalLogger.For(merchant.MerchantId).LogInformation($"Missed scheduled run at {scheduledRunUtc:O}. Scheduling an immediate catch-up run.");
                         return new ScheduledMerchant(merchant, scheduledRunUtc, now);