Merge pull request #151 from TransactionProcessing/task/#143_codact_password_issues

Refactor: centralize config keys in Constants class

Author: StuartFerguson

TestHosts/TestHosts/Controllers/DeveloperController.cs

@@ -18,7 +18,7 @@ namespace TestHosts.Controllers
     public class DeveloperController : ControllerBase
     {
         private readonly IDbContextResolver<PataPawaContext> ContextResolver;
-        private const String PataPawaReadModelKey = "PataPawaReadModel";
+        
         public DeveloperController(IDbContextResolver<PataPawaContext> contextResolver) {
             this.ContextResolver = contextResolver;
         }
@@ -27,7 +27,7 @@ public DeveloperController(IDbContextResolver<PataPawaContext> contextResolver)
         [Route("patapawaprepay/createuser")]
         public async Task<IActionResult> CreatePrepayUser([FromBody] CreatePatapawaPrePayUser request, CancellationToken cancellationToken){
 
-            using ResolvedDbContext<PataPawaContext>? resolvedContext = this.ContextResolver.Resolve(PataPawaReadModelKey);
+            using ResolvedDbContext<PataPawaContext>? resolvedContext = this.ContextResolver.Resolve(Constants.PataPawaReadModelConfig);
 
             Guid userId = Guid.NewGuid();
 
@@ -57,7 +57,7 @@ await resolvedContext.Context.PrePayUsers.AddAsync(new PrePayUser
         [Route("patapawaprepay/adduserdebt")]
         public async Task<IActionResult> AddUserDebt([FromBody] AddPatapawaPrePayUserDebt request, CancellationToken cancellationToken)
         {
-            using ResolvedDbContext<PataPawaContext>? resolvedContext = this.ContextResolver.Resolve(PataPawaReadModelKey);
+            using ResolvedDbContext<PataPawaContext>? resolvedContext = this.ContextResolver.Resolve(Constants.PataPawaReadModelConfig);
 
             PrePayUser user = await resolvedContext.Context.PrePayUsers.SingleOrDefaultAsync(u => u.UserName == request.UserName, cancellationToken);
 
@@ -75,7 +75,7 @@ public async Task<IActionResult> AddUserDebt([FromBody] AddPatapawaPrePayUserDeb
         [HttpPost]
         [Route("patapawaprepay/createmeter")]
         public async Task<IActionResult> CreatePrepayMeter([FromBody] CreatePatapawaPrePayMeter request, CancellationToken cancellationToken){
-            using ResolvedDbContext<PataPawaContext>? resolvedContext = this.ContextResolver.Resolve(PataPawaReadModelKey);
+            using ResolvedDbContext<PataPawaContext>? resolvedContext = this.ContextResolver.Resolve(Constants.PataPawaReadModelConfig);
 
             Guid meterId = Guid.NewGuid();
 
@@ -101,7 +101,7 @@ await resolvedContext.Context.PrePayMeters.AddAsync(new PrePayMeter
         public async Task<IActionResult> CreateHostConfiguration([FromBody] CreatePataPawaPostPayBill request,
                                                                  CancellationToken cancellationToken)
         {
-            using ResolvedDbContext<PataPawaContext>? resolvedContext = this.ContextResolver.Resolve(PataPawaReadModelKey);
+            using ResolvedDbContext<PataPawaContext>? resolvedContext = this.ContextResolver.Resolve(Constants.PataPawaReadModelConfig);
 
             Guid billIdentifier = Guid.NewGuid();
 

TestHosts/TestHosts/Database/PataPawa/PataPawaContext.cs

@@ -9,13 +9,12 @@ namespace TestHosts.Database.PataPawa
     public class PataPawaContext : DbContext
     {
         private readonly String ConnectionString;
-        private const String PataPawaReadModelKey = "PataPawaReadModel";
         public PataPawaContext()
         {
             // This is the migration connection string
 
             // Get connection string from configuration.
-            this.ConnectionString = ConfigurationReader.GetConnectionString(PataPawaReadModelKey);
+            this.ConnectionString = ConfigurationReader.GetConnectionString(Constants.PataPawaReadModelConfig);
         }
 
         public PataPawaContext(String connectionString)