Refactor: use constants for success codes/messages

Replaced hardcoded "SUCCESS" and "0000" strings with constants in TrainingTransactionService for better maintainability and consistency. Also condensed object initializations to single lines for improved code clarity. No changes to service logic or behavior.

Author: StuartFerguson

TransactionProcessor.Mobile.BusinessLogic/Services/TrainingModeServices/TrainingTransactionService.cs

@@ -7,104 +7,67 @@ namespace TransactionProcessor.Mobile.BusinessLogic.Services.TrainingModeService
 [ExcludeFromCodeCoverage]
 public class TrainingTransactionService : ITransactionService
 {
+    const String SuccessMessage = "SUCCESS";
+    const String SuccessResponseCode = "0000";
+
     public async Task<Result<PerformLogonResponseModel>> PerformLogon(PerformLogonRequestModel model,
                                                                       CancellationToken cancellationToken) {
-        return Result.Success(new PerformLogonResponseModel {
-                                                                                              EstateId = Guid.Parse("D7E52254-E0BE-436A-9A34-CC291DA0D66A"),
-                                                                                              MerchantId = Guid.Parse("DD034A3B-D8EE-45A4-A29F-8774751CEE76"),
-                                                                                              ResponseCode = "0000",
-                                                                                              ResponseMessage = "SUCCESS"
-                                                                                          });
+        return Result.Success(new PerformLogonResponseModel { EstateId = Guid.Parse("D7E52254-E0BE-436A-9A34-CC291DA0D66A"), MerchantId = Guid.Parse("DD034A3B-D8EE-45A4-A29F-8774751CEE76"), ResponseCode = SuccessResponseCode, ResponseMessage = SuccessMessage });
     }
 
     public async Task<Result<PerformMobileTopupResponseModel>> PerformMobileTopup(PerformMobileTopupRequestModel model,
-                                                                                  CancellationToken cancellationToken){
-
-        PerformMobileTopupResponseModel responseModel = model.TopupAmount switch{
-            150 => new PerformMobileTopupResponseModel(){
-                                                            ResponseCode = "1000",
-                                                            ResponseMessage = "Failed"
-                                                        },
-            _ => new(){
-                          ResponseCode = "0000",
-                          ResponseMessage = "SUCCESS"
-                      }
+                                                                                  CancellationToken cancellationToken) {
+
+        PerformMobileTopupResponseModel responseModel = model.TopupAmount switch {
+            150 => new PerformMobileTopupResponseModel() { ResponseCode = "1000", ResponseMessage = "Failed" },
+            _ => new() { ResponseCode = SuccessResponseCode, ResponseMessage = SuccessMessage }
         };
-        
+
         return Result.Success(responseModel);
     }
 
     public async Task<Result<PerformReconciliationResponseModel>> PerformReconciliation(PerformReconciliationRequestModel model,
                                                                                         CancellationToken cancellationToken) {
-        return Result.Success(new PerformReconciliationResponseModel {
-                                                                         ResponseMessage = "SUCCESS",
-                                                                         ResponseCode = "0000"
-                                                                     });
+        return Result.Success(new PerformReconciliationResponseModel { ResponseMessage = SuccessMessage, ResponseCode = SuccessResponseCode });
     }
 
     public async Task<Result<PerformVoucherIssueResponseModel>> PerformVoucherIssue(PerformVoucherIssueRequestModel model,
                                                                                     CancellationToken cancellationToken) {
 
-        PerformVoucherIssueResponseModel responseModel = model.VoucherAmount switch
-        {
-            150 => new ()
-                   {
-                       ResponseCode = "1000",
-                       ResponseMessage = "Failed"
-                   },
-            _ => new()
-                 {
-                     ResponseCode = "0000",
-                     ResponseMessage = "SUCCESS"
-                 }
+        PerformVoucherIssueResponseModel responseModel = model.VoucherAmount switch {
+            150 => new() { ResponseCode = "1000", ResponseMessage = "Failed" },
+            _ => new() { ResponseCode = SuccessResponseCode, ResponseMessage = SuccessMessage }
         };
-            
+
         return Result.Success(responseModel);
     }
 
     public async Task<Result<PerformBillPaymentGetAccountResponseModel>> PerformBillPaymentGetAccount(PerformBillPaymentGetAccountModel model,
-                                                                                                      CancellationToken cancellationToken){
-        PerformBillPaymentGetAccountResponseModel responseMessage = new PerformBillPaymentGetAccountResponseModel{
-                                                                                                                     BillDetails = new BillDetails{
-                                                                                                                                                      AccountName = "Mr Test Customer",
-                                                                                                                                                      AccountNumber = model.CustomerAccountNumber,
-                                                                                                                                                      Balance = "100.00",
-                                                                                                                                                      DueDate = DateTime.Now.AddDays(3).ToString("dd-MM-yyyy"),
-
-                                                                                                                                                  },
-                                                                                                                 };
+                                                                                                      CancellationToken cancellationToken) {
+        PerformBillPaymentGetAccountResponseModel responseMessage = new() {
+            BillDetails = new BillDetails {
+                AccountName = "Mr Test Customer", AccountNumber = model.CustomerAccountNumber, Balance = "100.00", DueDate = DateTime.Now.AddDays(3).ToString("dd-MM-yyyy"),
+            },
+        };
 
 
         return Result.Success(responseMessage);
     }
 
     public async Task<Result<PerformBillPaymentMakePaymentResponseModel>> PerformBillPaymentMakePayment(PerformBillPaymentMakePaymentModel model,
-                                                                                                        CancellationToken cancellationToken){
-
-        PerformBillPaymentMakePaymentResponseModel responseModel = model.PaymentAmount switch{
-            150 => new PerformBillPaymentMakePaymentResponseModel(){
-                                                                       ResponseMessage = "Failed",
-                                                                       ResponseCode = "1000"
-                                                                   },
-            _ => new PerformBillPaymentMakePaymentResponseModel{
-                                                                   ResponseCode = "0000",
-                                                                   ResponseMessage = "SUCCESS"
-                                                               }
+                                                                                                        CancellationToken cancellationToken) {
+
+        PerformBillPaymentMakePaymentResponseModel responseModel = model.PaymentAmount switch {
+            150 => new PerformBillPaymentMakePaymentResponseModel() { ResponseMessage = "Failed", ResponseCode = "1000" },
+            _ => new PerformBillPaymentMakePaymentResponseModel { ResponseCode = SuccessResponseCode, ResponseMessage = SuccessMessage }
         };
-        
+
         return Result.Success(responseModel);
     }
 
-    public async Task<Result<PerformBillPaymentGetMeterResponseModel>> PerformBillPaymentGetMeter(PerformBillPaymentGetMeterModel model, CancellationToken cancellationToken){
-        PerformBillPaymentGetMeterResponseModel responseMessage = new PerformBillPaymentGetMeterResponseModel
-        {
-                                                                      MeterDetails = new MeterDetails()
-                                                                                    {
-                                                                                        CustomerName = "Mr Test Customer",
-                                                                                        MeterNumber = model.MeterNumber
-                                                                                    }
-                                                                  };
-
+    public async Task<Result<PerformBillPaymentGetMeterResponseModel>> PerformBillPaymentGetMeter(PerformBillPaymentGetMeterModel model,
+                                                                                                  CancellationToken cancellationToken) {
+        PerformBillPaymentGetMeterResponseModel responseMessage = new PerformBillPaymentGetMeterResponseModel { MeterDetails = new MeterDetails() { CustomerName = "Mr Test Customer", MeterNumber = model.MeterNumber } };
 
         return Result.Success(responseMessage);
     }