Always record product details on a sale

Author: StuartFerguson

TransactionProcessor.BusinessLogic/Services/TransactionDomainService.cs

@@ -173,7 +173,7 @@ public async Task<ProcessSaleTransactionResponse> ProcessSaleTransaction(Guid tr
 
             (String responseMessage, TransactionResponseCode responseCode) validationResult =
                 await this.ValidateSaleTransaction(estateId, merchantId, deviceIdentifier, operatorIdentifier, transactionAmount, cancellationToken);
-
+            
             await this.TransactionAggregateManager.StartTransaction(transactionId,
                                                                     transactionDateTime,
                                                                     transactionNumber,
@@ -184,12 +184,12 @@ await this.TransactionAggregateManager.StartTransaction(transactionId,
                                                                     deviceIdentifier,
                                                                     transactionAmount,
                                                                     cancellationToken);
-            
+
+            // Add the product details 
+            await this.TransactionAggregateManager.AddProductDetails(estateId, transactionId, contractId, productId, cancellationToken);
+
             if (validationResult.responseCode == TransactionResponseCode.Success)
             {
-                // Add the product details 
-                await this.TransactionAggregateManager.AddProductDetails(estateId, transactionId, contractId, productId, cancellationToken);
-
                 // Record any additional request metadata
                 await this.TransactionAggregateManager.RecordAdditionalRequestData(estateId,
                                                                                    transactionId,