Merge pull request #1733 from TransactionProcessing/task/#1732_workflow_tweaks

Update CI workflows and Dockerfile for consistency

Author: StuartFerguson

.github/workflows/createrelease.yml

@@ -23,15 +23,7 @@ jobs:
       run: dotnet restore TransactionProcessor.sln --source ${{ secrets.PUBLICFEEDURL }} --source ${{ secrets.PRIVATEFEED_URL }}
 
     - name: Build Code
-      run: dotnet build TransactionProcessor.sln --configuration Release
-
-    - name: Run Unit Tests
-      run: |
-        echo "ASPNETCORE_ENVIRONMENT are > ${ASPNETCORE_ENVIRONMENT}"
-        dotnet test "TransactionProcessor.BusinessLogic.Tests\TransactionProcessor.BusinessLogic.Tests.csproj"
-        dotnet test "TransactionProcessor.ProjectionEngine.Tests\TransactionProcessor.ProjectionEngine.Tests.csproj"
-        dotnet test "TransactionProcessor.Aggregates.Tests\TransactionProcessor.Aggregates.Tests.csproj"
-        dotnet test "TransactionProcessor.Tests\TransactionProcessor.Tests.csproj"            
+      run: dotnet build TransactionProcessor.sln --configuration Release            
 
     - name: Publish Images to Docker Hub - Pre Release
       if: ${{ github.event.release.prerelease == true }} 

.github/workflows/nightlybuild.yml

@@ -50,10 +50,9 @@ jobs:
       run: dotnet test "TransactionProcessor.IntegrationTests\TransactionProcessor.IntegrationTests.csproj"
 
     - uses: actions/[email protected]
-      if: ${{ failure() }}
       with:
         name: tracelogs
-        path: /home/txnproc/trace/   
+        path: /home/runner/trace/   
 
     - uses: dacbd/create-issue-action@main
       if: ${{ failure() }}

.github/workflows/pullrequest.yml

@@ -62,10 +62,9 @@ jobs:
         dotnet test "TransactionProcessor.IntegrationTests/TransactionProcessor.IntegrationTests.csproj" --filter Category=PRTest  --configuration Release --no-build --verbosity normal --logger "trx;LogFileName=integration-test-results.trx"
 
     - uses: actions/[email protected]
-      if: ${{ failure() }}
       with:
         name: tracelogs
-        path: /home/txnproc/trace/   
+        path: /home/runner/trace/   
 
     - name: Publish test results
       uses: dorny/test-reporter@v1

TransactionProcessor/Dockerfile

@@ -24,10 +24,5 @@ RUN dotnet publish "TransactionProcessor.csproj" -c Release -o /app/publish
 
 FROM base AS final
 WORKDIR /app
-RUN groupadd --gid 10001 appuser \
-    && useradd --uid 10001 --gid appuser --shell /usr/sbin/nologin appuser \
-    && mkdir -p /home/txnproc/statements/outbound \
-    && chown -R appuser:appuser /home/txnproc
-COPY --from=publish --chown=appuser:appuser /app/publish .
-USER appuser
+COPY --from=publish /app/publish .
 ENTRYPOINT ["dotnet", "TransactionProcessor.dll"]