Merge pull request #1543 from TransactionProcessing/copilot/update-test-coverage-voucher-service

Add missing test coverage for VoucherDomainService failure paths

Author: StuartFerguson

NuGet.Config

@@ -6,7 +6,7 @@
   </packageSources>
 	<packageSourceCredentials>
 		<Feedz>
-			<add key="Username" value="TestUser"/>
+			<add key="Username" value="TestUser" />
 			<add key="ClearTextPassword" value="T-jXeJSPLLjOdZvRZOQ5O2e1vrQwRI7uxC1U" />
     	</Feedz>
 	</packageSourceCredentials>

TransactionProcessor.BusinessLogic.Tests/Services/VoucherDomainServiceTests.cs

@@ -193,6 +193,69 @@ public async Task VoucherDomainService_RedeemVoucher_VoucherNotFound_ErrorThrown
                                                                                   CancellationToken.None);
             result.IsFailed.ShouldBeTrue();
         }
+
+        [Fact]
+        public async Task VoucherDomainService_IssueVoucher_GetVoucherFailed_ErrorThrown() {
+            this.AggregateService.Setup(v => v.GetLatest<VoucherAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Failure());
+            this.AggregateService.Setup(f => f.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.Aggregates.EstateAggregateWithOperator()));
+
+            Result<IssueVoucherResponse> result = await this.VoucherDomainService.IssueVoucher(TestData.IssueVoucherCommand,
+                                                                                 CancellationToken.None);
+            result.IsFailed.ShouldBeTrue();
+        }
+
+        [Fact]
+        public async Task VoucherDomainService_IssueVoucher_SaveFailed_ErrorThrown() {
+            this.AggregateService.Setup(v => v.GetLatest<VoucherAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(new VoucherAggregate()));
+            this.AggregateService.Setup(v => v.Save(It.IsAny<VoucherAggregate>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Failure);
+            this.AggregateService.Setup(f => f.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.Aggregates.EstateAggregateWithOperator()));
+
+            Result<IssueVoucherResponse> result = await this.VoucherDomainService.IssueVoucher(TestData.IssueVoucherCommand,
+                                                                                 CancellationToken.None);
+            result.IsFailed.ShouldBeTrue();
+        }
+
+        [Fact]
+        public async Task VoucherDomainService_RedeemVoucher_GetVoucherAggregateFailed_ErrorThrown() {
+            this.AggregateService.Setup(v => v.GetLatest<VoucherAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Failure());
+            this.AggregateService.Setup(f => f.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.Aggregates.CreatedEstateAggregate()));
+
+            this.Context.VoucherProjectionStates.Add(new TransactionProcessor.Database.Entities.VoucherProjectionState() {
+                VoucherCode = TestData.VoucherCode,
+                OperatorIdentifier = TestData.OperatorIdentifier,
+                Barcode = TestData.Barcode,
+                Timestamp = BitConverter.GetBytes(DateTime.UtcNow.Ticks)
+            });
+            await this.Context.SaveChangesAsync();
+
+            Result<RedeemVoucherResponse> result = await this.VoucherDomainService.RedeemVoucher(TestData.EstateId,
+                                                                                  TestData.VoucherCode,
+                                                                                  TestData.RedeemedDateTime,
+                                                                                  CancellationToken.None);
+            result.IsFailed.ShouldBeTrue();
+        }
+
+        [Fact]
+        public async Task VoucherDomainService_RedeemVoucher_SaveFailed_ErrorThrown() {
+            this.AggregateService.Setup(v => v.GetLatest<VoucherAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
+                                      .ReturnsAsync(Result.Success(TestData.GetVoucherAggregateWithRecipientMobile()));
+            this.AggregateService.Setup(v => v.Save(It.IsAny<VoucherAggregate>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Failure);
+            this.AggregateService.Setup(f => f.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.Aggregates.CreatedEstateAggregate()));
+
+            this.Context.VoucherProjectionStates.Add(new TransactionProcessor.Database.Entities.VoucherProjectionState() {
+                VoucherCode = TestData.VoucherCode,
+                OperatorIdentifier = TestData.OperatorIdentifier,
+                Barcode = TestData.Barcode,
+                Timestamp = BitConverter.GetBytes(DateTime.UtcNow.Ticks)
+            });
+            await this.Context.SaveChangesAsync();
+
+            Result<RedeemVoucherResponse> result = await this.VoucherDomainService.RedeemVoucher(TestData.EstateId,
+                                                                                            TestData.VoucherCode,
+                                                                                            TestData.RedeemedDateTime,
+                                                                                            CancellationToken.None);
+            result.IsFailed.ShouldBeTrue();
+        }
 
         private EstateManagementContext GetContext(String databaseName)
         {