Skip to content

Add transaction timing metrics and related updates #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 1 commit into from
May 5, 2025

Add transaction timing metrics and related updates

0866a3a
Select commit
Loading
Failed to load commit list.
Refresh
Merged

Add transaction timing metrics and related updates #792

Add transaction timing metrics and related updates
0866a3a
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action May 5, 2025 in 0s

4 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 4
           

Complexity increasing per file
==============================
- TransactionProcessor.Database/Migrations/MySql/20250505085317_LoadTransactionTimings.cs  1
- TransactionProcessor.Database/Migrations/SqlServer/20250505085213_LoadTransactionTimings.cs  1
- TransactionProcessor.Database/Entities/TransactionTimings.cs  1
- TransactionProcessor.BusinessLogic/EventHandling/ReadModelDomainEventHandler.cs  1
         

Clones added
============
- TransactionProcessor.BusinessLogic.Tests/Services/TransactionDomainServiceTests.cs  5

See the complete overview on Codacy

Annotations

Check notice on line 345 in TransactionProcessor.BusinessLogic/Services/TransactionDomainService.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

TransactionProcessor.BusinessLogic/Services/TransactionDomainService.cs#L345 

Remove this empty statement.

Check notice on line 9 in TransactionProcessor.Database/Migrations/MySql/20250505085317_LoadTransactionTimings.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

TransactionProcessor.Database/Migrations/MySql/20250505085317_LoadTransactionTimings.cs#L9 

'partial' is gratuitous in this context.

Check notice on line 9 in TransactionProcessor.Database/Migrations/SqlServer/20250505085213_LoadTransactionTimings.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

TransactionProcessor.Database/Migrations/SqlServer/20250505085213_LoadTransactionTimings.cs#L9 

'partial' is gratuitous in this context.

Check failure on line 2064 in TransactionProcessor.Repository/ITransactionProcessorReadModelRepository.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

TransactionProcessor.Repository/ITransactionProcessorReadModelRepository.cs#L2064 

Rename parameter 'domainEvent' to 'de' to match the interface declaration.
View more details on Codacy Production