Merge branch 'master' into refactor/#611_process_sale_txn_parameters

Author: StuartFerguson

TransactionProcessorACL.Tests/General/ModelFactoryTests.cs

@@ -375,7 +375,7 @@ public void ModelFactory_ConvertFrom_ContractResponses_NullValue_IsConverted()
             List<Models.ContractResponse> model = null;
             List<DataTransferObjects.Responses.ContractResponse> dto = modelFactory.ConvertFrom(model);
 
-            dto.ShouldBeNull();
+            dto.Count.ShouldBe(0);
         }
 
         [Fact]

TransactionProcessorACL/Factories/ModelFactory.cs

@@ -182,13 +182,13 @@ public DataTransferObjects.Responses.MerchantResponse ConvertFrom(Models.Merchan
 
         public List<DataTransferObjects.Responses.ContractResponse> ConvertFrom(List<Models.ContractResponse> model)
         {
+            List<DataTransferObjects.Responses.ContractResponse> responses = new();
+
             if (model == null)
             {
-                return null;
+                return responses;
             }
 
-            List<DataTransferObjects.Responses.ContractResponse> responses = new();
-
             foreach (Models.ContractResponse contractModel in model)
             {
                 DataTransferObjects.Responses.ContractResponse contractResponse = new()