Merge pull request #481 from TransactionProcessing/codacy/high_fixes

fix of unused variable and other fixes

Author: StuartFerguson

TransactionProcessorACL.BusinessLogic/Services/TransactionProcessorACLApplicationService.cs

@@ -516,9 +516,7 @@ public async Task<Result<MerchantResponse>> GetMerchant(Guid estateId,
             }
             Logger.LogWarning("in GetMerchant - Got Token");
             TokenResponse accessToken = accessTokenResult.Data;
-
-            ProcessLogonTransactionResponse response = null;
-
+            
             Result<TransactionProcessor.DataTransferObjects.Responses.Merchant.MerchantResponse> result = await this.TransactionProcessorClient.GetMerchant(accessToken.AccessToken, estateId, merchantId, cancellationToken);
 
             if (result.IsFailed)
@@ -581,7 +579,7 @@ public async Task<Result<MerchantResponse>> GetMerchant(Guid estateId,
                 }
             }
 
-            if (result.Data.Contracts != null) {
+            if (result.Data.Devices != null) {
                 foreach (KeyValuePair<Guid, string> device in result.Data.Devices) {
                     merchantResponse.Devices.Add(device.Key, device.Value);
                 }

TransactionProcessorACL/Controllers/MerchantController.cs

@@ -240,7 +240,7 @@ public async Task<IActionResult> GetMerchant([FromQuery] String applicationVersi
         /// <summary>
         /// The controller name
         /// </summary>
-        public const String ControllerName = "merchants";
+        private const String ControllerName = "merchants";
 
         /// <summary>
         /// The controller route

TransactionProcessorACL/Controllers/TransactionController.cs

@@ -105,7 +105,7 @@ public async Task<IActionResult> PerformTransaction([FromBody] TransactionReques
                 case SaleTransactionRequestMessage msg:
                     TransactionCommands.ProcessSaleTransactionCommand saleCommand = this.CreateCommandFromRequest(claimsResult.Data.estateId, claimsResult.Data.merchantId, msg);
                     Result<ProcessSaleTransactionResponse> saleResponse = await this.Mediator.Send(saleCommand, cancellationToken);
-                    // TODO: Handle the result
+                    
                     if (saleResponse.IsFailed)
                         return saleResponse.ToActionResultX();
                     dto = this.ModelFactory.ConvertFrom(saleResponse.Data);
@@ -201,7 +201,7 @@ private TransactionCommands.ProcessReconciliationCommand CreateCommandFromReques
         /// <summary>
         /// The controller name
         /// </summary>
-        public const String ControllerName = "transactions";
+        private const String ControllerName = "transactions";
 
         /// <summary>
         /// The controller route

TransactionProcessorACL/Controllers/VoucherController.cs

@@ -147,7 +147,7 @@ public async Task<IActionResult> RedeemVoucher([FromQuery] String voucherCode,
         /// <summary>
         /// The controller name
         /// </summary>
-        public const String ControllerName = "vouchers";
+        private const String ControllerName = "vouchers";
 
         /// <summary>
         /// The controller route