"Expression: sequence not ordered" in debug mode

[tomysshadow]

This library works in Release builds, however in a Debug build it triggers the following assertion:

The error occurs when I create the SteamAppPathProvider object:

SteamAppPathProvider steamAppPathProvider;

and specifically on the following line:

    bool basicIncludeCompare(std::string::const_iterator start, std::string_view comp)
    {
        return std::includes(start, start+comp.length(), comp.cbegin(), comp.cend());
    }

This assertion seems to trigger in order to warn about undefined behaviour. From cppreference:

If [first1, last1) or [first2, last2) is not sorted with respect to comp, the behavior is undefined.

This doesn't seem trivial to fix because it looks like std::sort would need to be used on the ranges in order to make them valid for std::includes, but both of them are const so they cannot be modified. All of the iterators passed to this function would need to be made mutable (or alternatively - a different comparison method could be used, as it is probably not worth the hassle for what is effectively a strcmp??)

Visual Studio 2019. The issue occurs regardless of if I compile with /std:c++20 or /std:c++latest.

[Trico-Everfire]

Hey. @tomysshadow Thanks for the issue. SteamAppPathProvider is currently not being maintained anymore as it's support (and partially it's ownership) has been moved to Source Pretty Parsers. More specifically steampp.