-
-
Notifications
You must be signed in to change notification settings - Fork 217
Open
Labels
Description
Mentioned in #791 and is a follow up to #326
I've thought the recording mode should be at least a 3 way option.
Upon termination flag (transmission end):
- call is always closed, putting each transmission in a separate call (future transmissions are started based upon their grant messages by ignoring check for existing call)
- (current mode) file is closed but call is kept open
- file is kept open and closed on call end
To do conversation mode only involves:
- not closing the file in
end_transmission()
here https://github.com/robotastic/trunk-recorder/blob/e33e441278ae130a6884d464a5d75b97655ca5fd/trunk-recorder/gr_blocks/transmission_sink.cc#L224 - adding
close_wav()
tostop_recording()
https://github.com/robotastic/trunk-recorder/blob/e33e441278ae130a6884d464a5d75b97655ca5fd/trunk-recorder/gr_blocks/transmission_sink.cc#L257 sinceend_transmission()
will no longer do it - having a separate sample counter so that
close_wav()
creates a correct header - Ignoring or removing the error messages about the file not closing/being open
- modifying call concluder to handle the entire call being in the first transmission file
- Also need to move https://github.com/robotastic/trunk-recorder/blob/ca64f7a7f5aa48ac82196b43b3d04700f5825051/trunk-recorder/gr_blocks/transmission_sink.cc#L546-L547 outside of
transmission_sink::dowork
because on a termination flag they will not be reached due to https://github.com/robotastic/trunk-recorder/blob/ca64f7a7f5aa48ac82196b43b3d04700f5825051/trunk-recorder/gr_blocks/transmission_sink.cc#L483
Originally posted by @rosecitytransit in #791 (comment)
HarrisonWilson