Skip to content

Commit 75bfe36

Browse files
committed
Fix __del__ function
__del__ function isn't closing the connection properly as it is deleting the request rather than the manager, so store the PoolManager instance during __init__ and then delete it during __del__
1 parent 71a9c69 commit 75bfe36

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

opa_client/opa.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,22 +118,22 @@ def __init__(
118118
self.__headers.update({"User-Agent": generate_user_agent()})
119119

120120
if self.__secure:
121-
https = urllib3.PoolManager(
121+
self.__manager = urllib3.PoolManager(
122122
cert_reqs="CERT_REQUIRED",
123123
assert_hostname=False,
124124
ca_certs=self.__cert,
125125
headers=self.__headers,
126126
)
127-
self.__session = https.request
127+
self.__session = self.__manager.request
128128
else:
129-
https = urllib3.PoolManager(
129+
self.__manager = urllib3.PoolManager(
130130
headers=self.__headers
131131
)
132-
self.__session = https.request
132+
self.__session = self.__manager.request
133133

134134
def __del__(self):
135-
del self.__session
136-
135+
del self.__manager
136+
137137
def check_connection(self):
138138
"""
139139
Checks whether established connection config True or not.

0 commit comments

Comments
 (0)