obviousAlexC/newgroundsIO: use Scratch.external #2293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: change existing extension
GarboMuffin
changed the title
GarboMuffin
force-pushed
the
newgrounds-import
branch
from
1177c89 to
7f3674c
Compare
|
@David-Orangemoon do you have any complaints here? development version needs VM changes to run, but final built version inlines the script so it works the same as it currently does |
GarboMuffin
force-pushed
the
newgrounds-import
branch
from
7f3674c to
0dc6594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new imports instead of pasting the entire library in there.
In development, requires TurboWarp/scratch-vm@55674f8
But when using the final version that gets published on extensions.turbowarp.org, we inline the entire NGIO script in there so there is no dependency on any VM feature