Skip to content

delete! and empty Metadatas #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mhauru opened this issue Mar 12, 2025 · 0 comments
Open

delete! and empty Metadatas #839

mhauru opened this issue Mar 12, 2025 · 0 comments

Comments

@mhauru
Copy link
Member

mhauru commented Mar 12, 2025

As noted in #832 (comment)_, we are not very careful in how we deal with removing elements from VarInfo. delete! just doesn't work for TypedVarInfo, and subset is capable of creating TypedVarInfos where one of the sub-Metadatas is empty. We should fix delete! and test that empty Metadata objects are handled gracefully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhauru