Skip to content

Commit 9f70a3d

Browse files
authored
feat: clarify message "No typescript errors found." (#808)
When this message appears in context of webpack-dev-server, it could be unclear what kind of errors (webpack build vs. typescript). Sometimes there is a prior "Error checking in progress" message, but not always, and may be far above the "No errors found."
1 parent 147aa11 commit 9f70a3d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/hooks/tap-done-to-async-get-issues.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ function tapDoneToAsyncGetIssues(
6868
// print stats of the compilation
6969
config.logger.log(statsFormatter(issues, stats));
7070
} else {
71-
config.logger.log(chalk.green('No errors found.'));
71+
config.logger.log(chalk.green('No typescript errors found.'));
7272
}
7373

7474
// report issues to webpack-dev-server, if it's listening

test/e2e/driver/webpack-dev-server-driver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ function createWebpackDevServerDriver(
5757
process.stdout.on('data', (data) => {
5858
const content = stripAnsi(data.toString());
5959

60-
if (async && content.includes('No errors found.')) {
60+
if (async && content.includes('No typescript errors found.')) {
6161
noErrorsListener.resolve();
6262
}
6363

0 commit comments

Comments
 (0)