Skip to content

Commit a404b88

Browse files
GallectionsThatNerdSquared
authored andcommitted
fix: correcting cancel icon tags + correcting header links struture
1 parent 3ac5e13 commit a404b88

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

src/components/constants.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,11 @@ export const Col = styled.div`
5555
display: flex;
5656
flex-direction: column;
5757
`;
58-
export const Center = styled.div`
58+
59+
//
60+
export const Center = styled.li`
5961
display: flex;
60-
justify-content: center;
62+
justify-content: center;
6163
`;
6264

6365
export const Projects = [

src/components/header.jsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,11 @@ export default function Header() {
3636

3737
<NavBar.Links ref={drawerRef} openDrawer={openDrawer}>
3838
{links.map((l) => (
39+
<NavBar.li>
3940
<Link to={l.link}>
4041
<NavBar.Link>{l.name}</NavBar.Link>
4142
</Link>
42-
43-
44-
// The below code works but needs to ensure style consistency
45-
// <li key={l.name}>
46-
// <Link to={l.link}>
47-
// {l.name}
48-
// </Link>
49-
// </li>
43+
</NavBar.li>
5044
))}
5145
<Center>
5246
<CancelImageStyle
@@ -109,14 +103,20 @@ const NavBar = {
109103
openDrawer ? `translateX(0)` : `translateX(100%)`};
110104
}
111105
`,
112-
Link: styled.li`
106+
Link: styled.span`
113107
padding: 0 1rem;
114108
cursor: pointer;
115109
116110
@media only screen and (max-width: 600px) {
117111
padding: 1rem 0;
118112
}
119113
`,
114+
li: styled.li`
115+
cursor: pointer;
116+
117+
@media only screen and (max-width: 600px) {
118+
padding: 1rem 0;
119+
}`
120120
};
121121

122122
const CancelImageStyle = styled.img`

0 commit comments

Comments
 (0)