Skip to content

Commit fdfc2cc

Browse files
committed
small fix
1 parent f6ed468 commit fdfc2cc

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

assignment.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -134,17 +134,17 @@ def publish_assignments():
134134
db.session.rollback()
135135
return jsonify({"error": f"Failed to publish assignments: {str(e)}"}), 500
136136

137-
138137
def count_course_assignments():
139138
# Counts the number of times each user has taught each course
140-
assignment_counts = db.session.query(
139+
current_year = get_current_year()
140+
assignment_counts = (db.session.query(
141141
AssignmentDraft.user_id,
142142
AssignmentDraft.course_id,
143143
func.count(AssignmentDraft.course_id).label('count')
144-
).group_by(
144+
).filter(AssignmentDraft.course_year < current_year).group_by(
145145
AssignmentDraft.user_id,
146146
AssignmentDraft.course_id
147-
).all()
147+
).distinct().all())
148148

149149
return assignment_counts
150150

@@ -154,4 +154,5 @@ def count_course_assignments():
154154
@check_access_level(Role.ADMIN)
155155
def get_course_assignments_count():
156156
results = count_course_assignments()
157-
return jsonify(results=[{'user_id': user_id, 'course_id': course_id, 'count': count} for user_id, course_id, count in results])
157+
return jsonify(
158+
results=[{'user_id': user_id, 'course_id': course_id, 'count': count} for user_id, course_id, count in results])

course.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def add_course():
117117
@check_access_level(Role.ADMIN)
118118
def courses(year):
119119
courses = db.session.query(Course).filter_by(year=year).all()
120-
return render_template('courses.html', courses=courses, current_year=year)
120+
return render_template('courses.html', courses=courses, year=year)
121121

122122

123123
@course_bp.route('/search_teachers')

static/scripts/assignment_table.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -306,9 +306,9 @@ fetch('/assignment/load_data')
306306
// Coloration basée sur le nombre d'affectations
307307
const count = assignment.count;
308308
if (count === 1) {
309-
TD.style.backgroundColor = '#5DADE2';
310-
} else if (count === 2) {
311309
TD.style.backgroundColor = '#87CEEB';
310+
} else if (count === 2) {
311+
TD.style.backgroundColor = '#5DADE2';
312312
} else if (count >= 3) {
313313
TD.style.backgroundColor = '#0A74DA';
314314
}

templates/courses.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ <h4>Courses</h4>
5252
<tr class="course-item"
5353
data-organizations="{{ course.organizations | map(attribute='id') | join(',') }}">
5454
<td>
55-
<a href="{{ url_for("course.course_info", course_id=course.id, year=current_year) }}">
55+
<a href="{{ url_for("course.course_info", course_id=course.id, year=year) }}">
5656
{{ course.code }} - {{ course.title }}
5757
</a>
5858
</td>

0 commit comments

Comments
 (0)